fix(connection-limits): turn with_max_pending_incoming per peer - #6657
Merged
mergify[bot] merged 7 commits intoOct 1, 2026
Merged
Conversation
jxs
force-pushed
the
fix-connection-limits-per-peer-pending
branch
2 times, most recently
from
September 30, 2026 10:51
9cbe643 to
874a92a
Compare
jxs
force-pushed
the
fix-connection-limits-per-peer-pending
branch
from
September 30, 2026 10:57
874a92a to
99588e4
Compare
dknopik
reviewed
Sep 30, 2026
Relayed inbound connections have a `/p2p/<peer>` remote address, which the per-source bucketing rejected, even when no pending incoming limit was configured. All addresses that are neither IP-based nor `/memory/` now share a single bucket instead.
…pending_incoming_per_source The limit is now enforced per source rather than globally. Rename the setter so existing users get a compile error instead of a silent change in behaviour.
dknopik
force-pushed
the
fix-connection-limits-per-peer-pending
branch
from
October 1, 2026 17:22
0bb14bf to
e294445
Compare
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Merge Queue Status
This pull request spent 20 seconds in the queue, including 5 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes what I believe was a bug.
max_pending_incomingconnections was enforced globally and not per peer, which does not quite make sense as a peer can just fill all the slots and then other peers won't be able to connect.This PR fixes that by enforcing
max_pending_incomingconnections per peer.