Fix: lime sysupgrade lime owut

[a-gave]

• lime-owut: fix exec uci-defaults only once
• lime-system: fix lime-sysupgrade (fix 1285)

[ilario]

• lime-owut: fix exec uci-defaults only once

Ooh, right, you added this as the uci-defaults scripts would run again upon an update, right?
Do you consider we should eveeeentually check all the uci-defaults scripts and make sure they do not mess up after an update?

* lime-system: fix lime-sysupgrade (fix 1285)

Thanks! What about the leading slash (pointed out in #1285), should we document somewhere how to use lime-sysupgrade with files? Maybe just writing this here and removing the slash from /etc/sysupgrade.conf?

lime-packages/packages/lime-docs/files/www/docs/lime-example.txt

Line 34 in a15b581

minimum-essential /etc/sysupgrade.conf' # Files defining the list of files and directories to backup when upgrade. Relative to /lib/upgrade/keep.d if no '/' defined.

[a-gave]

• lime-owut: fix exec uci-defaults only once

Ooh, right, you added this as the uci-defaults scripts would run again upon an update, right?

Yes, it is meant to avoid duplicated configs among updates.

Do you consider we should eveeeentually check all the uci-defaults scripts and make sure they do not mess up after an update?

Not sure. It it much probably related to the usage of add_list that on its own do not avoid to add duplicated entries
So I think a recheck could be only needed for uci-defaults script that use the add_list function. But honestly is the first time that i face this issue, maybe other lime-packages do the same more cleanly. Will recheck soon

* lime-system: fix lime-sysupgrade (fix 1285)

Thanks! What about the leading slash (pointed out in #1285), should we document somewhere how to use lime-sysupgrade with files? Maybe just writing this here and removing the slash from /etc/sysupgrade.conf?

lime-packages/packages/lime-docs/files/www/docs/lime-example.txt

Line 34 in a15b581

minimum-essential /etc/sysupgrade.conf' # Files defining the list of files and directories to backup when upgrade. Relative to /lib/upgrade/keep.d if no '/' defined.

There was an error in my reporting: the leading / was just a fixable warning. The code was broken by the refactor linked to both shfmt (formatting) and shellcheck (linting). The script itself was ok before the two refactors: one has broken the calculation of the list of files to be preserved; the second the introduced a double quoting of this list (to make shellcheck happy) which has broken the recognition of this as an array by the posix /bin/sh. This has been fixed here with the introduction of # shellcheck disable=SC2086

[ilario]

Thanks!