Skip to content

Feat/final/presentation parameterisation - #110

Draft
jmacgowan wants to merge 31 commits into
libsemigroups:mainfrom
jmacgowan:feat/final/presentation-parameterisation
Draft

jmacgowan wants to merge 31 commits into
libsemigroups:mainfrom
jmacgowan:feat/final/presentation-parameterisation

Conversation

@jmacgowan

Copy link
Copy Markdown

Add parametric Presentation{W} support for Vector{Int} and String representations.

  • Parametric wrapper: Updated Presentation to Presentation{W} to support both integer (Vector{Int}) and character (String) words.
  • Default support: Presentation() still works and defaults to Vector{Int}.
  • Added _cxx_word to stop Presentation{String} from reaching non-updated C++ algorithms, will be abel to remove once other thing com in line.
  • Updated to.jl conversions to use _wrap_presentation so raw C++ outputs get wrapped back into Julia structs

jmacgowan and others added 24 commits September 21, 2026 10:16
Co-authored-by: Jake Swent <94636565+jswent@users.noreply.github.com>
Co-authored-by: Jake Swent <94636565+jswent@users.noreply.github.com>
Co-authored-by: Jake Swent <94636565+jswent@users.noreply.github.com>
…explicitly return `Presentation{Vector{Int}}` , added test, created some helpers to stop <string> being used where it should not be right now
@jmacgowan
jmacgowan marked this pull request as draft October 15, 2026 21:54
@jmacgowan

Copy link
Copy Markdown
Author

@jswent have a look, happy to change stuff if needed

@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.10744% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@b9b6b47). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/presentation.jl 96.17% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage        ?   75.06%           
=======================================
  Files           ?       21           
  Lines           ?     1648           
  Branches        ?        0           
=======================================
  Hits            ?     1237           
  Misses          ?      411           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants