Conversation
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. Automatic ready-for-review conversion failed; please mark the pull request ready manually if it is still a draft. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe routed catalog now excludes retired ChangesRouted catalog exclusion
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 42 / 80이 PR은 DeepSeek이 2026-09-14에 내려보낸 라인 메인테이너의 판단이 필요한 지점 라이브로 모델을 긁어 오는 제공자에서, 은퇴 모델을 레지스트리에서만 지우고 exclusion을 빼먹는 패턴이 또 생길 수 있습니다. 이번처럼 너의 추천 내용상 머지해도 되는 작은 버그픽스입니다. 작성자가 readiness 체크리스트를 채우고 draft를 푼 뒤 이 댓글은 grok-bot이 작성했습니다 |
48c2556 to
fd795db
Compare
|
Consolidated into #5529 in native Stack #5505. Source head: Source commits match by stable Git patch ID. Follow-up d11f35f fixes case-folded cap handling and moves the unchanged exclusion regression into a registered sibling file. Focused combined-head tests: 44 passed; prepared catalog tests: 515 passed. Full CI, docs build and independent review remain pending. Closing this duplicate standalone review entry at the author's request after verifying migration. This is not a merge or release claim; remaining integration checks and reviews are tracked on the draft replacement. Original branches are retained. |
Summary
deepseek-v4-prorouted-catalog exclusions insrc/codex/catalog/parsing.ts:deepseek/deepseek-v4-proandopencode-go/deepseek-v4-pro. DeepSeek retired the model on 2026-09-14 and both providers discover models live, so the exclusion is what keeps the retired, uncallable row out of dashboard and Codex pickers.structure/catalog.mdnow notes that retired aliases retained in generated metadata are covered.Verification
bun test tests/codex-integration/codex-catalog.test.ts— 339 pass, 0 failbun x tsc --noEmit— cleanChecklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
Bug Fixes
Documentation
Tests