Skip to content

fix(ci): register StepFun provider test in layout - #5330

Closed
Ingwannu wants to merge 1 commit into
devfrom
fix/register-stepfun-test-layout
Closed

Ingwannu wants to merge 1 commit into
devfrom
fix/register-stepfun-test-layout

Conversation

@Ingwannu

@Ingwannu Ingwannu commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • register tests/providers/stepfun-provider.test.ts in the repository-owned test layout as a providers test
  • update the checked layout fixture with the same mapping
  • restore the layout gates broken when feat(provider): add StepFun provider support #5313 added the test without registering it

This is the common dev failure currently surfacing in later pull requests as:

unresolved: providers/stepfun-provider.test.ts
unresolvedNew: stepfun-provider.test.ts

Verification

Using fresh temporary HOME, CODEX_HOME, and OPENCODEX_HOME:

bun test tests/test-layout.test.ts tests/test-layout-tooling.test.ts
18 pass, 0 fail

git diff --check is clean. bun run typecheck was attempted in the isolated worktree, but that worktree has no installed bun-types; this PR changes only the two JSON layout inventories and the focused executable gates pass.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Documentation is not affected; the checked test-layout fixture is updated with its source.
  • No authentication, credential, dependency, workflow, release, or runtime behavior changes.

Summary by CodeRabbit

  • Tests
    • Updated test layout mappings to include the StepFun provider test under the providers scope.
    • Updated the expected test-layout fixture to reflect the new mapping.

@Ingwannu
Ingwannu requested a review from lidge-jun as a code owner September 20, 2026 12:09
@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 20, 2026
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9a752b1d-18d9-42a9-8ae2-32fcd26773d2

📥 Commits

Reviewing files that changed from the base of the PR and between eb9a103 and be01df0.

📒 Files selected for processing (2)
  • scripts/test-layout/layout.json
  • tests/fixtures/test-layout-expected.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The test layout configuration and expected fixture add stepfun-provider.test.ts to the providers domain.

Changes

Test layout mapping

Layer / File(s) Summary
Provider test classification
scripts/test-layout/layout.json, tests/fixtures/test-layout-expected.json
The explicit mapping and expected fixture assign stepfun-provider.test.ts to providers. The fixture keeps the entry alphabetically sorted.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: registering the StepFun provider test in the test layout for CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun

Copy link
Copy Markdown
Owner

리뷰 · 우선순위 76 / 80

이 PR은 dev에서 깨진 테스트 배치(layout) 검사를 고칩니다. 조금 전에 합쳐진 #5313이 tests/providers/stepfun-provider.test.ts 파일을 넣었는데, “어느 묶음에 속하는지”를 적어 두는 두 JSON에는 이름을 안 넣었습니다. 그래서 나중에 열린 PR들의 게이트가 unresolved: providers/stepfun-provider.test.ts / unresolvedNew: stepfun-provider.test.ts로 실패하고 있습니다. 이번 변경은 scripts/test-layout/layout.jsontests/fixtures/test-layout-expected.json에 같은 한 줄(stepfun-provider.test.tsproviders)만 알파벳 순서에 맞게 추가합니다. 런타임·인증·의존성·문서 본문은 건드리지 않습니다. base는 dev이고, 작성자가 layout 관련 테스트 18개를 통과했다고 적었습니다. types.ts/config.ts 분할과 겹치지 않고, 같은 주제의 다른 열린 중복 PR도 없습니다.

라인 - scripts/test-layout/layout.json / tests/fixtures/test-layout-expected.json: 두 파일이 같은 키·같은 값으로 맞춰져 있고, 파일 경로(tests/providers/…)와 묶음 이름(providers)도 맞습니다. 코드 동작 문제는 보이지 않습니다.
라인 - CI: 이 댓글을 쓸 때 layout 게이트와 일부 test shard는 아직 돌고 있었습니다. 머지 전에 gates와 layout 관련 검사가 초록인지 한 번만 보면 됩니다. 미리보기 배포 이야기는 이 PR과 무관합니다.

메인테이너의 판단이 필요한 지점
없음. #5313이 이미 dev에 들어갔고, dev의 layout.json에만 stepfun 항목이 빠진 상태라 이 PR의 방향은 분명합니다. 묶음을 providers가 아니라 다른 도메인으로 옮길 이유도 없습니다.

너의 추천
CI layout/gates가 통과하면 바로 dev에 머지하세요. 범위가 두 JSON 한 줄씩뿐이라 되돌리기도 쉽고, 뒤에 열린 PR들의 공통 빨간불을 끄는 역할입니다. leftover·무효화할 중복 tip은 없습니다.

이 댓글은 grok-bot이 작성했습니다

@Ingwannu

Copy link
Copy Markdown
Owner Author

Exact-head status for be01df0ec09661db6d23edb6a4b8456fc7fd36d3: every Linux/Windows/general gate and both focused layout guards pass, including all four Linux shards and gates. The only failing required job is the repository-wide macos widget + bundle failure already reproduced on dev: the unsigned app build still requests an updater artifact and then requires a release signing key. This two-line JSON registration does not touch desktop packaging.

I am holding the merge because MAINTAINERS.md still requires required CI to pass. The narrow workflow correction is recorded on #5327 in #5327 (comment); once that lands, this PR needs a replacement exact-head run (or rebase onto the fixed dev) before maintainer integration.

@Ingwannu

Copy link
Copy Markdown
Owner Author

Superseded by #5335, merged into dev as d9cb0ebcb3aa4b46c3f6defe9358a65f2d394265. That commit adds the same stepfun-provider.test.ts -> providers entries to both layout inventories, and current origin/dev contains them. Closing this duplicate without merging; the branch is retained for audit.

@Ingwannu Ingwannu closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants