Skip to content

docs(devlog): close the brand icon unit with its on-screen and CI record - #5364

Merged
lidge-jun merged 1 commit into
devfrom
codex/260921-icon-unit-closure
Sep 20, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/260921-icon-unit-closure

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

the installed app in Finder and in the menu bar

the favicons in a real browser tab

  • Exact-head CI at 917d690ecb is green, including the aggregate ci check. The first attempt failed one job, macos 1/2, on tests/server/memory-watchdog.test.tsserializes only an allowlisted Bun runtime provenance ([Bug]: doctor repeats OPENCODEX_BUN_PATH guidance when a Bun canary override is already active #848) — at 47.4s against its own 20s timeout. That test makes eight full /api/system/memory route calls and its own comment records the route costing roughly 600ms per read on shared runners. It passed at 64b0eca2b0, which already carried both icon commits, and failed at 07e2ac9b41 before any of this landed; a focused local run finishes in 377ms. Re-running the job at the same SHA turned it and ci green. The flake is recorded rather than papered over — the fix is to stop that test paying for eight route snapshots, not to widen the timeout again, and that is separate scope.
  • Also corrects the icon check command in the plan: icons:check is a desktop package script and does not run from the repository root.

Verification

  • bun test tests/ci-workflows/brand-favicons.test.ts tests/ci-workflows/build-desktop-icon-set.test.ts tests/test-layout.test.ts — 14 pass, 0 fail.
  • Exact-head check-runs for 917d690ecb read at the SHA, distinguishing requested jobs from skipped ones: every requested job green, macos control / structure gate / the Windows shard placeholder skipped and named as such.
  • This change is documentation and two screenshots; no source or generated asset moves.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

The app icon, the menu bar mark and the two favicons all landed on dev. The unit moves
to _fin with what was actually observed: Finder and the Dock showing the mark on the
system rounded rectangle, the menu bar status item rendering the template with both
prompt glyphs as holes, and the two favicons read in a real browser tab rather than in
a composite. The two screenshots that back those claims are committed alongside.

Exact-head CI at 917d690 is green. The first attempt failed one job, macos 1/2, on a
memory-watchdog test that makes eight full /api/system/memory route calls and blew its
own 20s timeout at 47.4s on a loaded runner. It passed at 64b0eca, which already
carried both icon commits, and failed at 07e2ac9 before any of this landed; a focused
local run finishes in 377ms. Re-running the job at the same SHA turned it and the
aggregate ci check green. The flake is recorded rather than papered over: the fix is to
stop that test paying for eight route snapshots.

Also corrects the icon check command in the plan, which is a desktop package script and
does not run from the repository root.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 20, 2026 17:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-20T17:44:19.411178Z 287321c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: dab7027c-bfcd-4e24-97fe-e23b17b6f556

📥 Commits

Reviewing files that changed from the base of the PR and between 917d690 and 287321c.

⛔ Files ignored due to path filters (2)
  • assets/pr-screenshots/app-icon-finder-menubar.png is excluded by !**/*.png
  • assets/pr-screenshots/favicon-browser-tab.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • devlog/_fin/260921_brand_icon_and_menu_bar_mark/000_plan.md
  • devlog/_fin/260921_brand_icon_and_menu_bar_mark/010_favicons.md
  • devlog/_fin/260921_brand_icon_and_menu_bar_mark/020_closure.md
 ______________________________________________________________________________________________
< Rabbits with frickin' laser beams attached to their heads. And they're pointed at your bugs. >
 ----------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun
lidge-jun merged commit a499746 into dev Sep 20, 2026
27 of 28 checks passed
@lidge-jun
lidge-jun deleted the codex/260921-icon-unit-closure branch September 20, 2026 17:42
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant