docs(devlog): close the brand icon unit with its on-screen and CI record - #5364
Conversation
The app icon, the menu bar mark and the two favicons all landed on dev. The unit moves to _fin with what was actually observed: Finder and the Dock showing the mark on the system rounded rectangle, the menu bar status item rendering the template with both prompt glyphs as holes, and the two favicons read in a real browser tab rather than in a composite. The two screenshots that back those claims are committed alongside. Exact-head CI at 917d690 is green. The first attempt failed one job, macos 1/2, on a memory-watchdog test that makes eight full /api/system/memory route calls and blew its own 20s timeout at 47.4s on a loaded runner. It passed at 64b0eca, which already carried both icon commits, and failed at 07e2ac9 before any of this landed; a focused local run finishes in 377ms. Re-running the job at the same SHA turned it and the aggregate ci check green. The flake is recorded rather than papered over: the fix is to stop that test paying for eight route snapshots. Also corrects the icon check command in the plan, which is a desktop package script and does not run from the repository root.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
dev, so the unit moves fromdevlog/_plan/todevlog/_fin/with a terminal record.917d690ecbis green, including the aggregatecicheck. The first attempt failed one job,macos 1/2, ontests/server/memory-watchdog.test.ts— serializes only an allowlisted Bun runtime provenance ([Bug]: doctor repeats OPENCODEX_BUN_PATH guidance when a Bun canary override is already active #848) — at 47.4s against its own 20s timeout. That test makes eight full/api/system/memoryroute calls and its own comment records the route costing roughly 600ms per read on shared runners. It passed at64b0eca2b0, which already carried both icon commits, and failed at07e2ac9b41before any of this landed; a focused local run finishes in 377ms. Re-running the job at the same SHA turned it andcigreen. The flake is recorded rather than papered over — the fix is to stop that test paying for eight route snapshots, not to widen the timeout again, and that is separate scope.icons:checkis a desktop package script and does not run from the repository root.Verification
bun test tests/ci-workflows/brand-favicons.test.ts tests/ci-workflows/build-desktop-icon-set.test.ts tests/test-layout.test.ts— 14 pass, 0 fail.917d690ecbread at the SHA, distinguishing requested jobs from skipped ones: every requested job green,macos control/structure gate/ the Windows shard placeholder skipped and named as such.Checklist