Skip to content

test(cli): exercise the Windows installed-root isolation control with a real executable - #5595

Merged
lidge-jun merged 1 commit into
devfrom
codex/260923-windows-ci-fixes
Sep 22, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/260923-windows-ci-fixes

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

The Windows-only installed-root isolation case in tests/cli/cli-connect-readiness.test.ts (added with #5484 and carried in #5509) has never passed on Windows. Pull-request CI skips the Windows shards, so it reached dev. The full-platform run on dev fails shard 6/9 with lowerCalls: [] for both the inherited and isolated observations, while the installed sentinel is executed as expected.

The lower PATH candidate was a .cmd shim whose invocation recording did not happen on the Windows runner. On Windows the case now places a test-owned real codex.exe in the lower directory. It records that executable's completed --version launch through the injected execFileSync hook, which bypasses the resolver memo. The selected-runtime and installed-sentinel assertions are unchanged. The earlier PATH-key rewrite from #5592 did not affect the result and is removed.

Verification

  • Failure identified from Cross-platform CI run 35775691386 (windows 6/9).
  • The next full-platform dev run verifies the fix.
  • Local test, typecheck and build: NOT RUN (hosted CI only).

Checklist

  • Targets dev
  • No assertion loosened, no skip or timeout added; Linux and macOS paths unchanged

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 22, 2026 20:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T20:10:02.540305Z c087466 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun merged commit a077087 into dev Sep 22, 2026
1 of 7 checks passed
@lidge-jun
lidge-jun deleted the codex/260923-windows-ci-fixes branch September 22, 2026 20:07
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 034d1b84-4717-4c83-b511-376269aec2d6

📥 Commits

Reviewing files that changed from the base of the PR and between a4bdc03 and c087466.

📒 Files selected for processing (1)
  • tests/cli/cli-connect-readiness.test.ts
 ________________________________________________________________________________________________________________________________________
< It is a truth universally acknowledged, that a single developer in possession of a good feature, must be in want of an AI code review. >
 ----------------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant