test(cli): exercise the Windows installed-root isolation control with a real executable - #5595
Conversation
… a real executable
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The Windows-only installed-root isolation case in
tests/cli/cli-connect-readiness.test.ts(added with #5484 and carried in #5509) has never passed on Windows. Pull-request CI skips the Windows shards, so it reacheddev. The full-platform run ondevfails shard 6/9 withlowerCalls: []for both the inherited and isolated observations, while the installed sentinel is executed as expected.The lower PATH candidate was a
.cmdshim whose invocation recording did not happen on the Windows runner. On Windows the case now places a test-owned realcodex.exein the lower directory. It records that executable's completed--versionlaunch through the injectedexecFileSynchook, which bypasses the resolver memo. The selected-runtime and installed-sentinel assertions are unchanged. The earlier PATH-key rewrite from #5592 did not affect the result and is removed.Verification
devrun verifies the fix.Checklist
dev