-
Notifications
You must be signed in to change notification settings - Fork 1.3k
perf: make fragmented stream work linear #5837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
da9d51b
perf: make fragmented stream work linear
Ingwannu ffc203d
fix: normalize split surrogate byte accounting
Ingwannu de26479
docs(usage): state retained-window refresh cost
Ingwannu 6900bcf
Merge branch 'dev' into perf/stream-parser-scaling
lidge-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
structure/decisions/ADR-0102-incremental-stream-accounting.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # ADR-0102 — decision recorded under "Usage accounting" | ||
|
|
||
| - Contract owner: [Dashboard and usage](../dashboard-and-usage.md#usage-accounting) | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| ## Decision Log | ||
|
|
||
| - Purpose and intent: Keep proxy CPU and temporary allocation proportional to newly received bytes, | ||
| even when providers or child agents fragment a large logical frame into tiny chunks. | ||
| - Existing implementation and constraints: Serialized tool-call reconciliation must preserve exact | ||
| text and Markdown context; coding-agent JSONL must preserve streaming UTF-8, BOM, newline, and | ||
| byte-ceiling behavior; usage snapshots must still detect same-inode rewrites before reuse. | ||
| - Alternatives considered: Lower existing size limits; periodically flatten and rescan retained | ||
| text; use wall-clock performance assertions; or retain incremental parser/digest state. | ||
| - Selected approach: Scan only each new segment plus fixed delimiter overlap, maintain decoded JSONL | ||
| line-byte accounting while joining once per completed frame, and reuse a verified usage digest | ||
| only when both digest bounds are identical to the returned region. | ||
| - Why this approach: Smaller limits reduce functionality without removing quadratic work. Incremental | ||
| state preserves the existing wire contracts and gives deterministic work-count regression tests. | ||
| - Benefits, tradeoffs, and impact: CPU and cumulative allocation become linear for fragmented | ||
| streams and unchanged usage polling avoids a duplicate synchronous hash. The parsers carry small | ||
| additional state, and any change in usage-region bounds still requires a fresh digest. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.