Conversation
Render persisted Desktop profile slots as deterministic p-prefixed wire IDs so Claude Desktop does not collapse model changes after stripping terminal dates. Preserve legacy date and hash decoding while keeping genuine Anthropic identities authoritative.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
리뷰 · 우선순위 51 / 80이 PR은 Claude Desktop이 모델 이름을 비교할 때 맨 끝의 날짜를 지워서, 서로 다른 모델이 같은 이름으로 보이던 문제(#3782)를 고칩니다. 예전에는 관리되는 경로마다 이제는 파일에 저장하는 칸은 날짜 그대로 둡니다. Desktop에 보여줄 때만 이 코드를 넣은 뒤에는 Desktop 프로필을 다시 적용하고, Desktop을 완전히 껐다 켜야 새 이름이 들어갑니다. 이미 돌아가고 있던 작업은 예전 날짜 이름을 붙잡고 있을 수 있습니다.
메인테이너의 판단이 필요한 지점
너의 추천 이름 분리 방향은 #3782의 원인과 맞습니다. 날짜 칸은 파일 안에만 두고, Desktop으로 나가는 이름은 이 댓글은 grok-bot이 작성했습니다 |
…ted profile slot The remote-hub test on dev asserted the stored slot 20260211 as the Desktop wire id. With #5862 the slot stays stored but is emitted as claude-opus-4-8-p015, so Desktop's date stripping cannot collapse it onto a real dated Anthropic id. Routing through the emitted name is unchanged; only the name assertion moves. Co-authored-by: JSM2 <66578850+122yjs@users.noreply.github.com>
|
Thanks! This landed on |
Summary
p-prefixed wire IDs (for example,claude-opus-4-8-p01q) so Desktop does not collapse distinct managed routes after stripping terminalYYYYMMDDsuffixes.This addresses the active-session model-switch failure investigated in #3782. Existing generated Desktop profiles must be applied again to receive the new wire IDs.
Closes #3782
Verification
./node_modules/.bin/bun test tests/clients/desktop-3p.test.ts tests/clients/desktop-profile.test.ts tests/claude-integration/claude-desktop-discovery.test.ts tests/claude-integration/claude-models-discovery.test.ts tests/claude-integration/claude-desktop-picker-profile.test.ts tests/claude-integration/claude-messages-endpoint.test.ts tests/claude-integration/claude-native-passthrough.test.ts tests/claude-integration/claude-management-api.test.ts— 187 passed, 0 failed../node_modules/.bin/bun run typecheck— passed../node_modules/.bin/bun run structure:check— passed../node_modules/.bin/bun run privacy:scan— passed.git diff --check— passed.docs-site: ./node_modules/.bin/astro build— 521 pages built; 70,385 internal links checked../node_modules/.bin/bun run test:changed— 24,834 passed and 51 failed while this suite overlapped resource/port-heavy targeted tests. All 12 files containing those failures were then rerun sequentially: 517 passed, 0 failed.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.