fix(cli): derive catalog price estimates for models without manual overrides

[codingbooo]

Closes #5960

What

ocx models showed a blank or — price column for every catalog model that had no manual
price override in the config, even when the catalog itself advertises pricing metadata. Users
read that as "pricing is broken" rather than "no override is configured".

The CLI now derives a price estimate from the catalog entry when no manual override exists, and
labels it as derived so an authoritative override is never mistaken for it. An explicit override
still wins, and a model with neither source still reads as unknown rather than as free.

Scope

• src/cli/models.ts, src/cli/models-runtime.ts — derive the estimate from the catalog entry.
• docs-site/src/content/docs/reference/cli/providers-accounts.md — describe the derived/override
  distinction.
• tests/cli/cli-models-price.test.ts, tests/cli/cli-models.test.ts — cover derived, override and
  unknown cases.

Verification

• bun run typecheck clean
• bun test tests/cli/cli-models-price.test.ts tests/cli/cli-models.test.ts — passing
• bun run structure:check, bun run privacy:scan — clean

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

• Required local validation passed; commands, results, and any full-suite exception are documented.

• I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

• I resolved all correct Codex and CodeRabbit findings.

• My PR is ready for review.

Summary by CodeRabbit

• New Features
  • Model listings now show estimated input and output prices per million tokens when available, or indicate when pricing is unknown.
  • The price command now reports both saved manual prices and the effective price, including automatic estimates. Explicit manual prices—including zero—take precedence; unknown prices are returned as null.
• Documentation
  • Updated CLI references to explain price sources, precedence, and how to save provider-specific rates.

[github-actions]

✅ Deterministic PR hygiene checks passed.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d8ea43cf-f0b0-460b-9c44-2d5a9312709a

📥 Commits

Reviewing files that changed from the base of the PR and between 5744e7a and e1b73f2.

📒 Files selected for processing (6)

• docs-site/src/content/docs/reference/cli/providers-accounts.md
• src/cli/models-runtime.ts
• src/cli/models.ts
• structure/runtime.md
• tests/cli/cli-models-price.test.ts
• tests/cli/cli-models.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

---

📝 Walkthrough

Walkthrough

The CLI now displays estimated input and output prices for configured models. Its price query reports both saved manual costs and effective costs, including matched estimates when no manual override exists. Tests and documentation describe price precedence, zero-cost overrides, and unknown prices.

Changes

CLI model pricing

Layer / File(s)	Summary
Configured-model list pricing src/cli/models.ts, tests/cli/cli-models.test.ts	The listing resolves pricing for configured models and displays available input/output rates per 1M tokens, or “price unknown.” The test checks automatic prices, zero-valued user overrides, unknown prices, and that listing does not change the configuration.
Effective price query and reference src/cli/models-runtime.ts, tests/cli/cli-models-price.test.ts, docs-site/src/content/docs/reference/cli/providers-accounts.md, structure/runtime.md	The price query returns the saved cost and effectiveCost, falling back to a matched estimate or null. Tests cover automatic estimates and zero overrides. The documentation describes the output fields, price precedence, and read-time defaults that are not saved to modelCosts.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to e1b73

The change adds estimated prices while retaining manual overrides and unknown-price handling. No actionable merge-blocking risk is established by the supplied review evidence.

Security Architecture Review

Security architecture risk: 🔵 Low · up to e1b73

Model prices become visible through existing CLI commands, with manual overrides taking precedence. The review found no new privileged access path or change to how prices are saved, but coverage is incomplete.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The identified expansion is pricing data in existing CLI output, not a new remote entrypoint or an additional caller of the runtime write path.

Trust Boundaries and Controls

• observed — The price query checks the provider and model selector, rejects a model ID it cannot display safely, and validates the runtime response. The added fallback uses bundled pricing after the saved-cost lookup.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. (2 skipped: 2…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Issue #5960 requires provider model prices to be available by default. The PR resolves configured models with resolveMatchedPrice in src/cli/models.ts and reports effectiveCost in `src/cli/model…
Out of Scope Changes check	✅ Passed	The changed source files implement the linked pricing behavior. The CLI tests verify derived prices, manual precedence, unknown prices, and persistence behavior. The documentation changes describe the…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: deriving catalog price estimates for models that do not have manual price overrides. It matches the implementation, tests, documentation, and…

Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. (2 skipped: 2 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

✅ READY

• all PR quality gates passed; the review readiness checklist is complete.

Review readiness checklist

• ✅ Required local validation passed; commands, results, and any full-suite exception are documented.
• ✅ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
• ✅ I resolved all correct Codex and CodeRabbit findings.
• ✅ My PR is ready for review.

✅ 4/4 boxes ticked.

This pull request has been marked Ready for Review.
The review-ready label marks this PR as ready; review automation runs independently.
Maintainers notified: @lidge-jun @Ingwannu

[lidge-jun]

리뷰 · 우선순위 40 / 80

이 PR은 ocx models 목록에 모델 가격을 채웁니다. 설정에 직접 적어 둔 가격이 없으면, 프로그램에 들어 있는 공식 가격표에서 100만 토큰당 입력·출력 값을 읽어 보여 줍니다. 그 숫자는 설정 파일에 저장하지 않습니다. 가격표가 나중에 바뀌면 화면 숫자도 따라갑니다.

직접 적은 가격이 있으면 그 값이 이깁니다. 0도 직접 적은 값입니다. 가격표에도 없고 직접 적은 값도 없으면 화면은 price unknown입니다.

ocx models --json의 각 모델에 price가 생깁니다. ocx models price는 저장값 cost와 화면값 effectiveCost를 같이 냅니다. 테스트는 추정값, 0원 덮어쓰기, 모르는 모델을 확인합니다. 베이스는 dev입니다. 이슈 #5960을 닫는 PR은 이것뿐입니다.

라인 - src/cli/models.ts 435행. 사람이 읽는 목록은 추정 가격과 저장 가격을 같은 문장으로 찍습니다. 둘 다 ~$3/$15 input/output per 1M tokens입니다. 0으로 저장해도 ~$0/$0이라 짐작처럼 보입니다. JSON의 price.source와 ocx models price의 (automatic estimate)만 둘을 가릅니다. PR 본문은 추정값에 표시를 단다고 적혀 있습니다. 기본 목록 문장에는 그 표시가 없습니다. tests/cli/cli-models.test.ts도 저장값 줄의 문구는 검사하지 않습니다.

라인 - src/cli/models-runtime.ts 71행. ocx models live는 달러 가격을 아직 안 찍습니다. 실행 중에 발견한 모델은 여기 나옵니다. 이번 변경은 설정 파일에 적어 둔 모델 목록과, 모델 하나를 묻는 price만 다룹니다.

메인테이너의 판단이 필요한 지점

이슈 #5960은 단가가 비어 있어 하나씩 적기 귀찮다는 글입니다. 이 PR은 설정에 가격을 써 넣지 않습니다. 읽을 때만 추정값을 붙입니다. CLI 목록으로 이슈를 닫을지 정해 주세요.

대시보드 가격 창(gui/src/components/ModelPriceDialog.tsx)은 저장된 덮어쓰기만 읽고, 없을 때 입력칸을 비웁니다. 제보자가 그 창을 봤다면 빈칸은 그대로입니다.

중계 제공자에는 공식 회사 가격이 붙습니다. 테스트는 openai-chat 중계의 claude-sonnet-4-6에 입력 3, 출력 15를 기대합니다. 실제 청구액과 다를 수 있습니다. 물결표가 붙은 이 표시를 기본으로 둘지 정해 주세요.

너의 추천

방향은 맞으니 목록 문구만 고치고 머지하면 됩니다. 저장한 가격에는 물결표를 빼거나 저장값이라고 적으세요. 추정 가격만 자동 추정이라고 적으세요. 이슈를 닫기 전에 제보 화면이 ocx models인지 대시보드인지 확인하세요. 대시보드면 이 PR만으로 닫지 마세요. ocx models live에 같은 가격을 붙일지는 그 확인 다음에 정해도 됩니다.

이 댓글은 grok-bot이 작성했습니다

[Ingwannu]

Exact-head review at e1b73f2: the derivation and precedence logic are sound, but the human models listing does not preserve the advertised source distinction. src/cli/models.ts renders every available price with the same tilde form, including explicit user overrides and intentional zero prices. Thus a saved authoritative rate is presented as an estimate, and the focused human-output test only asserts the automatic row. Render automatic estimates and saved overrides differently, add assertions for both (including zero), and then obtain executable exact-head CI. Also confirm whether issue 5960 refers to this CLI surface before claiming the still-blank dashboard price editor is fixed.

[lidge-jun]

Landed on dev in #6059 (merge 8923ad9835) as one squashed commit that keeps your authorship. Thank you. Closing because this repository merges into dev, so GitHub does not close carried PRs automatically.