Repository navigation
fix(codex): preserve main locks on partial WHAM usage #6188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Separate all-plan block retention from long-window updates.
The parser does not update long-window usage for every plan. For
plan_type: "free"or"go", a primary window withused_percent: 64andlimit_window_seconds: 604800, null secondary, and omitted tertiary produces no quota observation.src/codex/plan.ts, Lines 14-17, selects monthly-only parsing.src/codex/quota.ts, Lines 909-915 and 931, returnsnullbecause monthly usage is absent.Preserve the all-plan claim for short-window block retention. Qualify the usage-update claim to cover only usage the parser accepts.
structure/providers/openai-tiers.md#L371-L372: Separate universal short-block retention from conditional long-window usage updates.docs-site/src/content/docs/reference/cli/providers-accounts.md#L174-L174: State that accepted long-window usage updates while the known short-window block remains retained for every plan.docs-site/src/content/docs/ko/reference/cli/providers-accounts.md#L111-L111: Apply the same qualification in Korean.As per coding guidelines, “Document current shipped or intentionally pending behavior.”
📍 Affects 3 files
structure/providers/openai-tiers.md#L371-L372(this comment)docs-site/src/content/docs/reference/cli/providers-accounts.md#L174-L174docs-site/src/content/docs/ko/reference/cli/providers-accounts.md#L111-L111🤖 Prompt for AI Agents
Source: Coding guidelines