Skip to content

Add python integration test for spontaneous keysend payments#923

Open
heyolaniran wants to merge 2 commits into
lightningdevkit:mainfrom
heyolaniran:feat/python_binding_test
Open

Add python integration test for spontaneous keysend payments#923
heyolaniran wants to merge 2 commits into
lightningdevkit:mainfrom
heyolaniran:feat/python_binding_test

Conversation

@heyolaniran

@heyolaniran heyolaniran commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Hello @tnull x @enigbe x @Camillarhi This commit adds the test_spontaneous_payment method which :

  • sets up two nodes in regtest environment, funds them, and opens channel
  • Arbitrary sends a 2.5M msat keysend with a custom TLV record
  • Asserts PAYMENT_SUCCESSFUL / PAYMENT_RECEIVED events
  • verify payment details Shared helpers (_setup_two_nodes, _fund_nodes, _open_channel_and_wait_ready, _stop_and_cleanup) reduce duplication for future integration

Motivation

The python bindings has not coverage for send_with_custom_tlvs

Run the new test

  • uv run --group dev python -m unittest src.ldk_node.test_ldk_node.TestLdkNode.test_spontaneous_payment -v

@ldk-reviews-bot

ldk-reviews-bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot ldk-reviews-bot requested a review from tnull June 5, 2026 17:50
@ldk-reviews-bot

ldk-reviews-bot commented Jun 8, 2026

Copy link
Copy Markdown

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull
tnull reviewed Jun 8, 2026
View reviewed changes

@tnull tnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is currently not available, so we'll need to wait a bit. One comment for now

Comment thread bindings/python/src/ldk_node/test_ldk_node.py Outdated
@heyolaniran heyolaniran force-pushed the feat/python_binding_test branch from 0a308cb to 8056689 Compare June 8, 2026 18:31
@heyolaniran heyolaniran requested a review from tnull June 11, 2026 21:57
@ldk-reviews-bot

ldk-reviews-bot commented Jun 15, 2026

Copy link
Copy Markdown

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull
tnull reviewed Jun 15, 2026
View reviewed changes
Comment thread bindings/python/src/ldk_node/test_ldk_node.py Outdated
Comment thread bindings/python/src/ldk_node/test_ldk_node.py
@heyolaniran
Introduce helpers for TestLdkNode
5e3396e 
this commits add some helpers like :
- setup_two_nodes, fund_nodes, open_channel_and_wait_ready, stop_and_cleanup
- find_two_free_ports to randomize port attributions and avoid collisions
- switch the test_channel_full_cycle to the new helpers
@heyolaniran
add test for spontaneous payment
3c9be11 
feat : introduces test_spontaneous_payment method which :
- setup two nodes and arbitrary send a 2.5 msat keysend with a custom tlv record
@heyolaniran heyolaniran force-pushed the feat/python_binding_test branch from 8056689 to 3c9be11 Compare June 15, 2026 17:23
@heyolaniran heyolaniran requested a review from tnull June 18, 2026 09:42
@ldk-reviews-bot

ldk-reviews-bot commented Jun 20, 2026

Copy link
Copy Markdown

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull Awaiting requested review from tnull

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heyolaniran @ldk-reviews-bot @tnull