Repository navigation
feat(queue): Queue page, and paste images into Generate - #449
Closed
lightningpixel wants to merge 2 commits into
Closed
lightningpixel wants to merge 2 commits into
lightningpixel wants to merge 2 commits into
Conversation
A new Queue page (Manage, after Library) follows every job from one place:
- Running: the workflow started in this window with its live steps and
elapsed time, plus any generation the backend is running.
- Queued: generations waiting for the single backend worker.
- History: past runs, newest first, with "Load more".
Each run shows its name, an input or output thumbnail, step progress,
elapsed time and status; a finished mesh opens in Generate or is shown
in the Library (which now selects and scrolls to it).
Backend: run records get parent_run_id. Model nodes of a workflow pass it
when they start a generation, so the history lists the workflow once and
its generations as its steps (GET /workflow-runs?top_level=true,
GET /workflow-runs/{id}/children).
Workflow records now take their input image from the Image nodes
(they were empty when started from Generate).
Closes #412
Ctrl+V outside text fields puts a clipboard image into Generate's first image input; the empty input hints at it. The image node needs a file path, so the pasted image is saved to <workspace>/Images/ through a narrow workspace:images:save IPC (PNG, JPEG or WebP checked by signature, 40 MB cap, sanitized unique names, never overwrites, never in tmp/). Part of #420 (the Image Studio page ships with background removal, #421).
Owner
Author
|
Replaced by #450, which also includes the Image Studio page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #412 · Part of #420
Queue page (#412)
A new Queue page (Manage, after Library) follows every job from one place:
Each run shows its name, an input or output thumbnail, step progress, elapsed time and status. A finished mesh opens in Generate or is shown in the Library, which now selects and scrolls to it. Expanding a workflow run lists its steps and the generations it started.
Under the hood:
parent_run_id; workflow model nodes pass it when they start a generation, so history lists a workflow once with its generations as its steps (GET /workflow-runs?top_level=true,GET /workflow-runs/{id}/children).workflowRunStoreexposes the live run (useLiveWorkflowRun) without changing existing consumers.Out of scope: cancel / retry / reorder (#413), run detail (#414), top-bar indicator (#415), a real priority queue (#322).
Paste into Generate (part of #420)
Ctrl+V outside text fields puts a clipboard image into Generate's first image input. The pasted image is saved to
<workspace>/Images/through a narrowworkspace:images:saveIPC (PNG / JPEG / WebP checked by signature, 40 MB cap, sanitized unique names, never overwrites, never intmp/).The Image Studio page itself (#420) will ship together with background removal (#421), so it doesn't land empty.
Testing
npm testpasses (Python 460, JS 331 + 237, 0 failures); lint clean;tscunchanged fromdevqueueModel.test.ts,workflowRunRecord.test.tsadditions,test_run_history.py(+13 cases),workspace-images.test.ts,imageInput.test.ts