Repository navigation
Rename BiDiServer to WebDriverServer and drop the aliases - #17
Merged
Merged
Conversation
The server speaks classic WebDriver as well as BiDi, so BiDiServer named only half of it, and #16 added WebDriverServer / AsyncWebDriverServer as aliases. Two public names for one class is one too many: make WebDriverServer and AsyncWebDriverServer the classes and remove BiDiServer and AsyncBiDiServer outright. The module moves from lightpanda.bidi to lightpanda.webdriver to match. This breaks imports of BiDiServer, which shipped in 1.0.0.
arrufat
added a commit
to lightpanda-io/docs
that referenced
this pull request
Oct 8, 2026
lightpanda-python drops BiDiServer for WebDriverServer with no alias (lightpanda-io/lightpanda-python#17), so the alias handling in the reference generator has nothing left to resolve: remove it. Point the Python guide's robots.txt note at WebDriverServer and regenerate the reference against that branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BiDiServernamed only half of what the server speaks, so #16 addedWebDriverServer/AsyncWebDriverServeras aliases. Two public names for one class is one too many, so this makesWebDriverServerandAsyncWebDriverServerthe classes and removesBiDiServerandAsyncBiDiServerwith no alias or deprecation shim. The module moves fromlightpanda.biditolightpanda.webdriver, the tests and fixture follow, and the alias test goes away.Breaking:
from lightpanda import BiDiServer(shipped in 1.0.0) stops working.The aliases also broke the docs' Python reference generator (lightpanda-io/docs#124), which gets updated alongside this.