Repository navigation
Use --no-sync in uv run to keep resolved benchmark env - #18
Merged
Merged
Conversation
uv run re-syncs the venv against the project's declared dependencies, which don't include lsdb/numba, so numpy gets upgraded past numba's supported range (currently to 2.5, breaking the lsdb import). --no-sync keeps the environment resolved by the install step, where numba's numpy pin is respected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=====================================
Coverage 3.48% 3.48%
=====================================
Files 26 26
Lines 1062 1062
=====================================
Hits 37 37
Misses 1025 1025 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dougbrn
approved these changes
Jul 6, 2026
dougbrn
left a comment
dougbrn
left a comment
Contributor
There was a problem hiding this comment.
just swinging by on interrupts to review this, looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv run re-syncs the venv against the project's declared dependencies, which don't include lsdb/numba, so numpy gets upgraded past numba's supported range (currently to 2.5, breaking the lsdb import). --no-sync keeps the environment resolved by the install step, where numba's numpy pin is respected.