Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ColumnSpec maps flat and nested catalog columns to tensors. resolve() validates against catalog meta (nested sub-column dtypes come from NestedDtype.column_dtypes) without computing data, and reports every problem at once. Nested columns are padded to the batch maximum with a mask and lengths, fully vectorized via nest.len() and nest.to_flat(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6 +/- ##
===========================================
- Coverage 100.00% 95.59% -4.41%
===========================================
Files 2 5 +3
Lines 7 295 +288
===========================================
+ Hits 7 282 +275
- Misses 0 13 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
First implementation PR for the initial design (docs/design/initial-design.md, §4).
Solution Description
lsdb>=0.11andtorch>=2.4as core dependencies.ColumnSpec/Flat/Nested: maps flat and nested catalog columns to tensors.resolve()validates against catalog meta (nested sub-column types viaNestedDtype.column_dtypes) without computing any data, and reports every problem in one error.<key>_maskand<key>_lengths, fully vectorized withnest.len()/nest.to_flat(). Rows with empty or null nested values have length 0. Options:max_lengthwith head/tail truncation,pad_to,pad_value, null fill,transform=.resolve_device/move_batchhelpers (default "cpu", "auto" opt-in).Tests compare against a per-row reference implementation and include a fixture catalog that raises if any partition is computed.
Note: CI only triggers on
main, so this PR gets no CI untildevis added to the workflow triggers (design doc §12).🤖 Generated with Claude Code