Move abs() from SimdFloat to SimdBase, implement it on integers - #371
Merged
Conversation
LaurenzV
approved these changes
Sep 6, 2026
| OpSig::Unary, | ||
| "Compute the absolute value of each element.\n\n\ | ||
| Unsigned integers are unchanged. Signed integers use wrapping absolute value: \ | ||
| the minimum representable value remains unchanged. This matches `i32::abs()`.\n\n\ |
Collaborator
There was a problem hiding this comment.
Probably wrapping_abs would be the better comparison, right?
Contributor
Author
There was a problem hiding this comment.
Since we don't panic in debug mode, yes, that's more accurate. I think it's less clear though.
Contributor
Author
There was a problem hiding this comment.
I'm not married to it, so I'll change it if you insist.
Collaborator
There was a problem hiding this comment.
Not insisting 😄 as you want
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is technically API-breaking so I'd like to get it done before v1.0
Implements wrapping semantics, same as
i32::abs(). We can add a saturating variant later, since it doesn't require API changes.