Repository navigation
chore(examples): fix vite-project-react-swc type check on lingui v6 - #2749
Merged
Merged
Conversation
`yarn build` runs `tsc` first, and it failed with TS2307 for every `@lingui/*` import: Lingui v6 ships its types only through `exports`, which `moduleResolution: "Node"` doesn't read. Switch to `"bundler"` (needs TypeScript 5), and bump `@types/react` / `@types/react-dom` to 18.3 so `Trans` and `Plural` (which return `ReactNode`) type-check as JSX components. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
size-limit report 📦
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
yarn buildrunstscfirst, and it failed with TS2307 for every@lingui/*import: Lingui v6 ships its types only throughexports, whichmoduleResolution: "Node"doesn't read. Switch to"bundler"(needs TypeScript 5), and bump@types/react/@types/react-domto 18.3 soTransandPlural(which returnReactNode) type-check as JSX components.Types of changes
Checklist