Repository navigation
fix(native-tools): honor ctx.sourceMaps in createSwcExtractor - #287
Merged
Merged
Conversation
Wrapper extractors (e.g. @lingui/extractor-vue) pass the map of the compiled code in ctx.sourceMaps, as the Babel extractor expects. The native extractor ignored it and reported positions in the compiled code. Append the map as an inline source map comment before extraction. The native side reads the last such comment, so ctx.sourceMaps takes precedence over an inline map already in the code, as in the Babel extractor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
=======================================
Coverage 94.42% 94.42%
=======================================
Files 11 11
Lines 2530 2530
=======================================
Hits 2389 2389
Misses 141 141
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
3 of 8 tasks
…eMaps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
timofei-iatsenko
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createSwcExtractor()ignoredctx.sourceMaps. When another extractor wraps it and passes the source map of its compiled code there, as@lingui/extractor-vuedoes, message origins pointed to the compiled code instead of the original file and line. The Babel extractor readsctx.sourceMapsfirst, so the two extractors gave different origins.The extractor now appends that map as an inline source map comment before extraction. The native side reads the last such comment, so
ctx.sourceMapstakes precedence over an inline map already in the code, the same as in the Babel extractor. This is a JS-only change, and the Rust side is unchanged.Found while reviewing lingui/js-lingui#2729, which adds an inline map in the Vue extractor to work around this.