Repository navigation
RabbitPublisher: set ContentType and DeliveryMode from Message; add t… - #10
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The constructor change breaks binary compatibility, and the new tests are not executed by CI.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds RabbitMQ content type and delivery-mode support, plus JSON publisher configuration and tests.
Changes:
- Maps message metadata to RabbitMQ properties.
- Adds JSON publisher options, documentation, tests, and version 6.1.0.
- Registers the test project in the solution.
| File | Description |
|---|---|
src/RabbitMessagePublisher.cs |
Applies content type and delivery mode. |
src/JsonMessagePublisher.cs |
Adds publishing options. |
src/Linn.Common.Messaging.RabbitMQ.csproj |
Bumps package version. |
tests/.../RabbitPublisherTests.cs |
Tests metadata publishing. |
tests/.../Linn.Common.Messaging.RabbitMQ.Tests.csproj |
Defines the test project. |
README.md |
Documents new options. |
Linn.Common.Messaging.RabbitMQ.sln |
Adds the test project. |
changelog.md |
Records the 6.1.0 release. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+9
to
+11
| JsonSerializerOptions? serializerOptions = null, | ||
| string? contentType = null, | ||
| bool persistent = false) |
| EndProject | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{0AB3BF05-4346-4AA6-1389-037BE0695223}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Linn.Common.Messaging.RabbitMQ.Tests", "tests\Linn.Common.Messaging.RabbitMQ.Tests\Linn.Common.Messaging.RabbitMQ.Tests.csproj", "{5F62DC6D-9E1E-4932-B350-926F444EDAA4}" |
richardiphillips
approved these changes
Oct 2, 2026
…istent as init properties; CI runs tests Addresses PR review: adding optional constructor parameters changed the CLR signature, so assemblies compiled against 6.0.x could hit MissingMethodException. The constructor is now unchanged (pinned by a reflection test) and the new options are init properties. CI gains a dotnet test step so the test project actually runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ests; 6.1.0