Repository navigation
fix: broken multi-line tag replacement - #3664
Merged
Merged
Conversation
tawera-manaena
approved these changes
Oct 12, 2026
Merged
olitreadwell
pushed a commit
to olitreadwell/basemaps
that referenced
this pull request
Oct 13, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>8.22.1</summary> ## [8.22.1](linz/basemaps@v8.22.0...v8.22.1) (2026-10-12) ### Bug Fixes * broken multi-line tag replacement ([linz#3664](linz#3664)) ([b39b97b](linz@b39b97b)) </details> <details><summary>infra: 8.13.1</summary> ## [8.13.1](linz/basemaps@infra-v8.13.0...infra-v8.13.1) (2026-10-12) ### Dependencies * The following workspace dependencies were updated * devDependencies * @basemaps/lambda-tiler bumped from ^8.13.3 to ^8.13.4 </details> <details><summary>lambda-tiler: 8.13.4</summary> ## [8.13.4](linz/basemaps@lambda-tiler-v8.13.3...lambda-tiler-v8.13.4) (2026-10-12) ### Bug Fixes * broken multi-line tag replacement ([linz#3664](linz#3664)) ([b39b97b](linz@b39b97b)) </details> <details><summary>server: 8.10.18</summary> ## [8.10.18](linz/basemaps@server-v8.10.17...server-v8.10.18) (2026-10-12) ### Dependencies * The following workspace dependencies were updated * devDependencies * @basemaps/lambda-tiler bumped from ^8.13.3 to ^8.13.4 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: linz-github-automation[bot] <249205945+linz-github-automation[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Multiline replacements are breaking after a formatting change split a tag across multiple lines, adding a full html parser for a simple replace seemed like it would be too heavy so a simple regexp replace was chosen
ref: 7bc78cd
Modifications
Regex replace meta tags rather than '\n' splitting
Verification
Unit tests