Skip to content

fix: broken multi-line tag replacement - #3664

Merged
blacha merged 1 commit into
masterfrom
fix/broken-tags
Oct 12, 2026
Merged

blacha merged 1 commit into
masterfrom
fix/broken-tags

Conversation

@blacha

@blacha blacha commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Motivation

Multiline replacements are breaking after a formatting change split a tag across multiple lines, adding a full html parser for a simple replace seemed like it would be too heavy so a simple regexp replace was chosen

ref: 7bc78cd

Modifications

Regex replace meta tags rather than '\n' splitting

Verification

Unit tests

@blacha
blacha marked this pull request as ready for review October 12, 2026 01:51
@blacha
blacha requested a review from a team as a code owner October 12, 2026 01:51
@blacha
blacha added this pull request to the merge queue Oct 12, 2026
Merged via the queue into master with commit b39b97b Oct 12, 2026
15 checks passed
@blacha
blacha deleted the fix/broken-tags branch October 12, 2026 01:56
olitreadwell pushed a commit to olitreadwell/basemaps that referenced this pull request Oct 13, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>8.22.1</summary>

## [8.22.1](linz/basemaps@v8.22.0...v8.22.1)
(2026-10-12)


### Bug Fixes

* broken multi-line tag replacement
([linz#3664](linz#3664))
([b39b97b](linz@b39b97b))
</details>

<details><summary>infra: 8.13.1</summary>

##
[8.13.1](linz/basemaps@infra-v8.13.0...infra-v8.13.1)
(2026-10-12)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @basemaps/lambda-tiler bumped from ^8.13.3 to ^8.13.4
</details>

<details><summary>lambda-tiler: 8.13.4</summary>

##
[8.13.4](linz/basemaps@lambda-tiler-v8.13.3...lambda-tiler-v8.13.4)
(2026-10-12)


### Bug Fixes

* broken multi-line tag replacement
([linz#3664](linz#3664))
([b39b97b](linz@b39b97b))
</details>

<details><summary>server: 8.10.18</summary>

##
[8.10.18](linz/basemaps@server-v8.10.17...server-v8.10.18)
(2026-10-12)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @basemaps/lambda-tiler bumped from ^8.13.3 to ^8.13.4
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: linz-github-automation[bot] <249205945+linz-github-automation[bot]@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
preprod — 37cf634a Deployed Oct 12, 2026 by blacha via validate screenshots #3898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants