Repository navigation
ME-4054: Remove support for v3.4 - #193
Merged
Merged
Conversation
kacperf531
approved these changes
Oct 21, 2026
There was a problem hiding this comment.
🟡 Changes recommended
Explicit v3.4 webhook parsing raises an internal AttributeError instead of a controlled validation error.
1 open issue
What changed in this PR
Removes LiveChat API v3.4 support across clients and webhook parsing, retaining versions 3.5–3.7.
Changes:
- Deletes v3.4 implementations and removes their factory registrations and return types.
- Removes v3.4 references from webhook tests.
- Records the removal in the changelog.
| File | Description |
|---|---|
| livechat/webhooks/v34.py | Deletes v3.4 webhook models. |
| livechat/webhooks/parser.py | Removes v3.4 parsing support. |
| livechat/tests/test_wh_parser.py | Removes v3.4 imports and fixture mapping. |
| livechat/reports/base.py | Removes v3.4 client selection. |
| livechat/reports/api/v34.py | Deletes v3.4 Reports client. |
| livechat/customer/web/base.py | Removes v3.4 client selection. |
| livechat/customer/web/api/v34.py | Deletes v3.4 Customer Web client. |
| livechat/customer/rtm/base.py | Removes v3.4 client selection. |
| livechat/customer/rtm/api/v34.py | Deletes v3.4 Customer RTM client. |
| livechat/configuration/base.py | Removes v3.4 client selection. |
| livechat/configuration/api/v34.py | Deletes v3.4 Configuration client. |
| livechat/agent/web/base.py | Removes v3.4 client selection. |
| livechat/agent/web/api/v34.py | Deletes v3.4 Agent Web client. |
| livechat/agent/rtm/base.py | Removes v3.4 client selection. |
| livechat/agent/rtm/api/v34.py | Deletes v3.4 Agent RTM client. |
| changelog.md | Documents v3.4 support removal. |
Review effort: Balanced
| ''' | ||
| webhook_data_class = { | ||
| '3.4': WebhookV34, | ||
| '3.5': WebhookV35, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.