Repository navigation
fill only up to the amount we need - #926
Merged
Merged
Conversation
Shiverwarp
approved these changes
Oct 4, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
…-fill-to fill only up to the amount we need
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does two things, broadly:
getFuel() < targetUnits(as one would expect for a function calledfillTorather thanfillBy), we were ultimately filling by targetUnits in the amount of fuel we tried to obtain.retrievecalls, but should save meat.If we decide that the addition mall hits caused by
2are undesirable (I would expect it to take ~3 buy-cycles for most fuels, which isn't really that much), we should close this out but still fix1however we see fit.