Prod release: support unicode in data, load local jsPsych (dev) - #1934
Draft
becky-gilbert wants to merge 2 commits into
Draft
Prod release: support unicode in data, load local jsPsych (dev)#1934becky-gilbert wants to merge 2 commits into
becky-gilbert wants to merge 2 commits into
Conversation
jsPsych local plugin overlay
* use utf-8 encoding for psychds download tmp files: write_overview_to_tmp_file for resp/child overviews; write for all responses JSON in render_to_response (fixes ascii cannot encode character error) * use utf-8 encoding for frame data dict: less likely but possible for researchers to use unicode in frame IDs and keys * add tests for non-ascii characters in all changed file operations
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the following changes into production:
JSPSYCH_LOCAL_PLUGINS(jsPsych local plugin overlay #1933) environment variable, which, when set to True, replaces the DB-defined published package URLs with local versions for chs-jspsych plugins.