Repository navigation
SSW-3052: Create script to perform M2 rigid body motions. - #250
Merged
Merged
Conversation
edennihy
reviewed
Oct 9, 2026
edennihy
left a comment
edennihy
left a comment
Contributor
There was a problem hiding this comment.
First set of of comments to consider.
|
|
||
|
|
||
| class WarmUpM2(salobj.BaseScript): | ||
| """Warm up the M2 mirror after it has been idle for a long time. |
Contributor
There was a problem hiding this comment.
Might want to be clear here that we're not warming up the M2 mirror glass, maybe we could say Warm up the M2 mirror rigid support system to differentiate?
| and negative directions. It moves in discrete steps, adapting the step | ||
| size based on the result of each movement. | ||
|
|
||
| This is the M2 equivalent of `WarmUpHexapod`. Since |
Contributor
There was a problem hiding this comment.
Again, can say M2 rigid support equivalent
| def __init__(self, index, remotes: bool = True): | ||
| super().__init__( | ||
| index=index, | ||
| descr="Warm up the M2 mirror by moving it to its extremes in " |
Contributor
There was a problem hiding this comment.
Same as above, Warm up the M2 mirror support system
|
|
||
| self.m2_name = "m2" | ||
| self.move_timeout = 60.0 | ||
| self.aget_timeout = 5.0 |
Contributor
There was a problem hiding this comment.
Could you just use the fast_timeout here?
|
|
||
| return False | ||
|
|
||
| async def _unmute_alarm(self, is_mutted: bool, alarm_name: str) -> None: |
Contributor
There was a problem hiding this comment.
If we don't expect the CSC state to change during the script, we should remove this method as well.
tribeiro
force-pushed
the
tickets/SSW-3052
branch
from
October 12, 2026 20:27
c497e97 to
81d3916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.