forked from lidge-jun/opencodex
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(chat-native): share transient send budget across recovery #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+30
−3
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d35592b
merge dev into main for the v2.32.1 release
lidge-jun 71c57ea
release: v2.32.1
lidge-jun d560ac6
merge dev into main for the v2.33.0 release
lidge-jun 08ada6f
Merge pull request #2553 from lidge-jun/codex/promote-main-2330
lidge-jun ec51e42
release: v2.33.0
lidge-jun e25b653
merge dev into main for the v2.34.0 release
lidge-jun 80fff9a
Merge pull request #2760 from lidge-jun/codex/promote-main-2340
lidge-jun fc4de77
Merge pull request #2826 from lidge-jun/codex/promote-main-2350
lidge-jun c7d8407
Merge pull request #3002 from lidge-jun/codex/promote-main-2360
lidge-jun c1716f4
fix(chat-native): share transient send budget across recovery
luvs01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These assertions only match implementation strings, so they can remain green even if the counter or guards are placed on a path that does not constrain dispatches. The existing
tests/chat-completions-endpoint.test.tsrecovery test exercises 429 retry and key rotation without enablingtransientRetryOn5xx, leaving the changed interaction untested. Add an endpoint regression with transient retry enabled, a 429/5xx recovery sequence, and an assertion that actual upstream calls never exceedattempts.AGENTS.md reference: AGENTS.md:L336-L339
Useful? React with 👍 / 👎.