security: block loopback-bootstrapped GUI sessions from mutating machine state - #410
security: block loopback-bootstrapped GUI sessions from mutating machine state#410luvs01 wants to merge 20 commits into
Conversation
release: promote dev into main for v2.32.1
# Conflicts: # package.json
[WRONG BRANCH] merge dev into main for the v2.33.0 release
Promotes the dev integration line onto main. The resulting tree is byte-identical to origin/dev, including package.json at 2.34.0. The package.json conflict is resolved to dev's side, NOT to main's stale 2.33.0. Earlier promotions (lidge-jun#2553, lidge-jun#2507) kept the target's version so the release bump would land on its own "release: vX.Y.Z" commit. That is no longer legal: this very delta adds tests/release-version-line.test.ts, which fails when the in-tree version sits behind the highest release tag. With v2.34.0-preview.20260827 now published, 2.33.0 orders behind it, so a promotion carrying the stale line turns CI red on every shard that runs the suite. The consequence for the release step is that scripts/release.ts skips the bump (release.ts:568, currentVersion === version), so v2.34.0 gets tagged on this merge commit rather than on a separate release commit. The workflow creates the tag itself after publishing and validates expected-sha against the checked-out commit, so the tag still names exactly the audited tree.
[WRONG BRANCH] promote dev onto main for v2.34.0
[WRONG BRANCH] promote dev onto main for v2.35.0
[WRONG BRANCH] promote dev onto main for v2.36.0
[WRONG BRANCH] promote dev to main for the v2.37.0 release
[WRONG BRANCH] promote dev onto main for v2.38.0
[WRONG BRANCH] promote dev onto main for v2.39.0
release: promote dev to main for v2.40.0
…rkflow call (lidge-jun#3262) Both v2.40.0 release dispatches (33615174183 preview, 33615177849 main) died at startup_failure: a workflow_call cannot grant its callee more than the calling job holds, and dev-version-bump.yml's job declares contents+pull- requests write. lidge-jun#3129 wired the call but never dispatched a release, so this is its first live run. The caller job now declares exactly the callee's two permissions; no other job in release.yml gains anything. Co-authored-by: jun <jun@lidge.dev> (cherry picked from commit 7ce0ba5)
…400-relfix release: carry the release.yml permissions fix onto main for v2.40.0
|
✅ Deterministic PR hygiene checks passed. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
changed the title
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88613a259d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (req.method !== "GET" && req.method !== "HEAD") { | ||
| return Response.json({ error: "opencodex machine changes require the local CLI" }, { status: 403 }); |
There was a problem hiding this comment.
When the dashboard is served by a connected client, it still exposes actions that POST to these machine endpoints: disconnect in gui/src/App.tsx:221-227, sync in gui/src/pages/Integrations.tsx:72-80, and shim repair/removal in gui/src/pages/Startup.tsx:105-117. This unconditional method guard makes every one of those controls return 403 for every connected-dashboard user; sync and shim actions silently do nothing, while disconnect reports an error. Remove or disable the controls for connected clients and direct users to the corresponding CLI commands, with the user-facing behavior documented.
AGENTS.md reference: AGENTS.md:L343-L344
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
luvs01
changed the title
2 participants
Motivation
Description
src/client/machine-listener.tsso agui-sessionobtained via the loopback bootstrap can be used for status/diagnosticGETreads but will receive403for state-changing requests (non-GET/HEAD) to/api/machine/*rather than authorizing durable machine mutations.tests/client-machine-listener.test.tsto assert the new behavior: authenticated reads still succeed while loopback-bootstrapped attempts to call/api/machine/sync,/api/machine/shim(POST), and/api/machine/disconnectnow return403and have no side effects.src/client/machine-listener.tsand the corresponding focused tests intests/client-machine-listener.test.tsonly, keeping the fix minimal and focused on the authorization boundary.Testing
./node_modules/.bin/bun test tests/client-machine-listener.test.tsand they passed (all assertions updated to expect403for blocked mutations)../node_modules/.bin/bun run typecheckand./node_modules/.bin/bun run privacy:scan, both succeeded../node_modules/.bin/bun run test) but observed unrelated environment- and integration-level failures and timeouts in unrelated suites; the full-suite run was therefore not used as the primary validation for this focused security fix.Codex Task