Skip to content

fix(responses): disable unsafe custom websocket upstreams - #415

Open
luvs01 wants to merge 20 commits into
Devfrom
codex/propose-fix-for-websocket-vulnerability
Open

fix(responses): disable unsafe custom websocket upstreams#415
luvs01 wants to merge 20 commits into
Devfrom
codex/propose-fix-for-websocket-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Motivation

  • An opt-in upstreamWebsocket path allowed arbitrary configured HTTPS Responses endpoints to enter Bun's WebSocket client path, but Bun's client API assembles complete messages (including fragmented text/binary frames) before JS handlers run, letting a malicious upstream force unbounded allocations and crash the process.
  • The safe immediate mitigation is to keep non-canonical/custom providers on the bounded HTTP/SSE relay until the runtime can enforce an inbound message-size limit during ingestion; preserve the canonical ChatGPT fast WS path.

Description

  • Restrict upstream WebSocket eligibility so only the canonical ChatGPT Responses URL is eligible and arbitrary provider URLs never take the native WebSocket lane by returning false from shouldUseCodexWsUpstream for non-canonical URLs and rejecting non-canonical dial attempts in wsUpstreamUrlFor (changes in src/server/responses/ws-upstream.ts).
  • Gate the dialing path in codexWsUpstreamFetch to fall back to the HTTP/SSE helper when the request URL is not the canonical Responses URL or the runtime lacks the bounded relay capability (change in src/server/responses/ws-upstream.ts).
  • Keep upstreamWebsocket as a compatibility config flag but mark it ignored for custom providers and update multi-locale docs to state this (changes in docs-site/src/content/docs/**/reference/configuration/providers.md).
  • Update tests to assert that opted-in custom providers remain on bounded HTTP/SSE and to cover the fallback behavior (changes in tests/ws-upstream.test.ts).

Testing

  • Ran the focused WebSocket suite with a bounded Bun runtime: npx --yes bun@1.4.0 test tests/ws-upstream.test.ts --timeout 15000, which passed the suite (39 passed, 1 skipped).
  • Verified typecheck and other repository checks: npx --yes bun@1.4.0 x tsc --noEmit and npx --yes bun@1.4.0 run privacy:scan completed successfully, and the docs build for docs-site completed (cd docs-site && npx --yes bun@1.4.0 install --frozen-lockfile && npx --yes bun@1.4.0 run build).
  • Attempted the full test suite (npx --yes bun@1.4.0 run test) but observed pre-existing unrelated timeouts / lab assertions outside the touched WebSocket surface; the focused WebSocket tests that validate the security fix pass with the required runtime.

Codex Task

lidge-jun and others added 20 commits August 25, 2026 10:36
release: promote dev into main for v2.32.1
# Conflicts:
#	package.json
[WRONG BRANCH] merge dev into main for the v2.33.0 release
Promotes the dev integration line onto main. The resulting tree is byte-identical
to origin/dev, including package.json at 2.34.0.

The package.json conflict is resolved to dev's side, NOT to main's stale 2.33.0.
Earlier promotions (lidge-jun#2553, lidge-jun#2507) kept the target's version so the release bump
would land on its own "release: vX.Y.Z" commit. That is no longer legal: this very
delta adds tests/release-version-line.test.ts, which fails when the in-tree version
sits behind the highest release tag. With v2.34.0-preview.20260827 now published,
2.33.0 orders behind it, so a promotion carrying the stale line turns CI red on
every shard that runs the suite.

The consequence for the release step is that scripts/release.ts skips the bump
(release.ts:568, currentVersion === version), so v2.34.0 gets tagged on this merge
commit rather than on a separate release commit. The workflow creates the tag itself
after publishing and validates expected-sha against the checked-out commit, so the
tag still names exactly the audited tree.
[WRONG BRANCH] promote dev onto main for v2.34.0
[WRONG BRANCH] promote dev onto main for v2.35.0
[WRONG BRANCH] promote dev onto main for v2.36.0
[WRONG BRANCH] promote dev to main for the v2.37.0 release
[WRONG BRANCH] promote dev onto main for v2.38.0
[WRONG BRANCH] promote dev onto main for v2.39.0
…rkflow call (lidge-jun#3262)

Both v2.40.0 release dispatches (33615174183 preview, 33615177849 main) died
at startup_failure: a workflow_call cannot grant its callee more than the
calling job holds, and dev-version-bump.yml's job declares contents+pull-
requests write. lidge-jun#3129 wired the call but never dispatched a release, so this
is its first live run. The caller job now declares exactly the callee's two
permissions; no other job in release.yml gains anything.

Co-authored-by: jun <jun@lidge.dev>
(cherry picked from commit 7ce0ba5)
…400-relfix

release: carry the release.yml permissions fix onto main for v2.40.0
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T06:07:17.899444Z 3efbf0e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: da7445dc-7810-413d-a565-a58f3a149e32


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

✅ READY

  • all PR quality gates passed.

Hygiene

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title fix(responses): disable unsafe custom websocket upstreams [WRONG BRANCH] fix(responses): disable unsafe custom websocket upstreams Sep 3, 2026
@github-actions github-actions Bot added the bug Something isn't working label Sep 3, 2026
@github-actions
github-actions Bot marked this pull request as draft September 3, 2026 06:05
@luvs01 luvs01 changed the title [WRONG BRANCH] fix(responses): disable unsafe custom websocket upstreams fix(responses): disable unsafe custom websocket upstreams Sep 3, 2026
@luvs01
luvs01 changed the base branch from main to dev September 3, 2026 06:21
@github-actions
github-actions Bot marked this pull request as ready for review September 3, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants