-
Notifications
You must be signed in to change notification settings - Fork 0
[WRONG BRANCH] fix(cursor): remove spoofable connection status #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,12 +5,10 @@ | |
| * this proxy: its settings live in a SQLite database the running app rewrites and its API key | ||
| * in the OS keychain, both out of bounds for opencodex. So this route only answers the three | ||
| * questions the dashboard needs — which Cursor builds are installed, what to paste into the | ||
| * gateway form, and whether a Cursor client has actually called `/v1/models` since the proxy | ||
| * started — plus which active models will show Cursor's Reasoning and Context controls. | ||
| * gateway form, and which active models will show Cursor's Reasoning and Context controls. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
After this route stops returning the last-seen signal, AGENTS.md reference: src/AGENTS.md:L29-L29 Useful? React with 👍 / 👎. |
||
| */ | ||
| import { readRuntimePort } from "../../config/process-state"; | ||
| import { filterCatalogVisibleModels, nativeContextLimits, nativeOpenAiContextTier, uniqueCatalogModelsForRawPublicList, visibleNativeSlugs } from "../../codex/catalog"; | ||
| import { cursorLastSeen, type CursorSeen } from "../../integrations/cursor-seen"; | ||
| import { detectCursorInstalls, type CursorInstall } from "../../integrations/cursor-detect"; | ||
| import { configuredApiAuthToken, isApiAuthRequired, jsonResponse } from "../auth-cors"; | ||
| import { fetchAllModels } from "../management-api"; | ||
|
|
@@ -24,7 +22,6 @@ export interface CursorIntegrationStatus { | |
| privateInference: { installed: boolean; path: string | null; version: string | null }; | ||
| regularCursor: { installed: boolean; path: string | null }; | ||
| gateway: { baseUrl: string; apiKeyMode: "credential" | "placeholder"; placeholder: string }; | ||
| lastSeen: CursorSeen | null; | ||
| models: Array<{ | ||
| id: string; | ||
| reasoning: string[] | null; | ||
|
|
@@ -83,7 +80,6 @@ export async function buildCursorIntegrationStatus( | |
| apiKeyMode, | ||
| placeholder: CURSOR_GATEWAY_PLACEHOLDER_KEY, | ||
| }, | ||
| lastSeen: cursorLastSeen(), | ||
| models, | ||
| guideUrl: CURSOR_GUIDE_URL, | ||
| }; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever Private Inference is installed, this unconditional
absentstate renders the literal “Not applied” badge and excludes Cursor from the applied count, including when Cursor is correctly configured. Since this code explicitly acknowledges that the configuration cannot be verified, the change replaces spoofable false positives with deterministic false negatives; use an unknown/unverifiable visual state while continuing not to count it as applied.Useful? React with 👍 / 👎.