Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: luvs01/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
accessSnapshot keyed apiBaseUrl validation on the routed slot name, so a custom provider resolved through the Devin OAuth definition dropped its stored tenant URL and sent the token to the US default. The validated host now follows the resolved OAuth definition instead. Co-Authored-By: Epinephrine <luvs01@hanmail.net>
…al's token Co-Authored-By: Epinephrine <luvs01@hanmail.net>
|
이관됨: lidge-jun#6038 |
|
동일 수정이 상류 저장소에 제출되어 이 포크 PR의 목적은 달성됐습니다. |
Motivation
route.providerNamebut the search path always consumed the canonicaldevinOAuth slot, allowing scoped keys to spend a different account's quota.Description
src/server/search.tsto forwardroute.providerNametohandleDevinAlphaSearchinstead of the constant"devin".getValidAccessTokenSnapshotinsrc/oauth/index.tsto accept anoauthProvideroption and letresolveAccessSnapshotForAccountconsult the requested OAuth provider definition when performing refresh logic.src/web-search/devin-executor.tsto request the OAuth refresh implementation (oauthProvider: "devin") while resolving the account snapshot for the routed credential slot, preserving Devin's refresh semantics without forcing a canonical slot selection.tests/server/api-key-scope-alpha-search.test.tsthat creates both a customteam-devincredential and a canonicaldevincredential and asserts the upstream request uses only the scoped provider's token; also updatestructure/runtime.mdto document the invariant.Testing
bun test tests/server/api-key-scope-alpha-search.test.ts tests/web-search/devin-web-search.test.tsand observed all tests pass (13 passed, 0 failed).bun run typecheck, structure validation withbun run structure:check, and privacy scan withbun run privacy:scan, each completing successfully.bun run test:changedcould not run due to missing comparison refs in this checkout, so focused import-connected tests were executed instead and reported green.Codex Task