Repository navigation
Fix SandFS copy release test and release Agent 0.5.2 - #294
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.5.1 macOS release reached the SandFS task integration test and failed because it always unmounted the copy. SandFS 0.9 intentionally uses cloned real folders on macOS and on reflink-capable Linux filesystems.
Keep the complete task lifecycle assertions for both backends and exercise unmount/remount only when the copy is an actual filesystem mount, identified by its device boundary. Unpushed commits, dirty files, tags, stashes, push-back and clean removal remain covered. No production code changes. Bump all three crates and Cargo.lock to 0.5.2, preserving the pushed failed release tags.
Validation: reproduced the original failure locally; the corrected integration test passes. The full macOS cargo test --offline --locked --workspace suite passes, including all 12 Sonny task integration tests and 313 Sonny unit tests (one existing ignored test). cargo fmt --check, cargo metadata --offline --locked and git diff --check pass.