Repository navigation
Stop exited companions’ descendants before restarting - #371
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A companion that exits while its descendants remain alive currently restarts without stopping the old process group. For example, a command that backgrounds a child and exits can accumulate processes across restarts, and those descendants outlive daemon shutdown.
Retain the group ID before reaping the leader and run the existing asynchronous SIGTERM/grace/SIGKILL cleanup before restarting. Explicit removal and shutdown use the same cleanup. This adds no work to socket requests, bot scheduling, or store writes; the existing nonblocking companion lifecycle performs the cleanup.
Validation: a new regression test reproduced the leaked descendant before the fix and passes afterward, alongside the existing companion lifecycle tests on macOS. The full macOS workspace Rust suite, clippy with warnings denied, formatting and diff checks pass using the repository-pinned Rust 1.98.0. The workspace run required scoped escalation after sandboxed Unix socket tests returned
Operation not permitted. CI and automated review remain required before merging.Release recovery for the remaining process-group finding in #370.