Repository navigation
Fix printing consistency across inventory and decks - #7
Open
HunterCustom wants to merge 12 commits into
Open
HunterCustom wants to merge 12 commits into
HunterCustom wants to merge 12 commits into
Conversation
HunterCustom
marked this pull request as draft
August 30, 2026 13:40
HunterCustom
marked this pull request as ready for review
September 9, 2026 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several cases where Deck Lotus could display or link to a different printing than the one actually selected in a user's inventory or deck.
What changed
printing_idstored in the deck.Why
Previously, the card artwork shown in Inventory or a Deck could represent one printing while the card detail modal, pricing, or marketplace link represented another.
For example, a deck could display a CMM printing of a card while the detail modal and TCGPlayer link opened the C14 printing.
This change keeps the selected printing consistent throughout the UI and database behavior.
Testing
The equivalent behavior was manually tested on a self-hosted Deck Lotus Docker installation, including:
The source-level changes in this PR mirror the patches used during that testing.
There does not appear to be an automated test suite defined in the current
package.json, so additional maintainer testing is welcome.