Repository navigation
Conversation
Allow creating inbox placement tests from the CLI with the same dry-run/--yes guard as preview run, then poll GET /v4/inbox/results until the test settles.
Poll inbox-placement result with the same timeout defaults as preview, update the human spinner after create, and shorten the README QA sections.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mailgun inbox-placement runso Optimize inbox placement tests can be created from the CLI.--dry-run/--yesguard aspreview run, then pollsGET /v4/inbox/results/{id}until the test settles or the timeout is reached.Test plan
npm testmailgun inbox-placement run --from <verified-from> --subject "CLI test" --html ./email.html --dry-run --jsonmailgun inbox-placement run --from <verified-from> --subject "CLI test" --html ./email.html --yes --json(Optimize-enabled account; consumes quota and sends to seeds)mailgun agent-contextlistsinbox-placement runasmode: writemailgun inbox-placement result <result_id> --json