Repository navigation
CI: skip the coverage check on fork PRs, don't fail fast - #400
Merged
Merged
Conversation
Pull requests from forks get a read-only GITHUB_TOKEN, so simplecov-check-action fails with 403 "Resource not accessible by integration" when it creates its check run, after the tests have already passed. Only run it on pushes and same-repo PRs. Also disable fail-fast so one failing Ruby version no longer cancels the rest of the matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests from forks always fail the
test (4.0)job: the tests pass, butjoshmfrankel/simplecov-check-actionthen tries to create a check run with aGITHUB_TOKENthat is read-only on fork PRs and fails with403 Resource not accessible by integration(e.g. #393, #387). With the defaultfail-fast, that also cancels whichever other Ruby versions are still running.fail-fast: falseso each Ruby version reports its own result.