MT-23324: replace internal field names in email campaigns spec - #48
Open
Rabsztok wants to merge 1 commit into
Open
MT-23324: replace internal field names in email campaigns spec#48Rabsztok wants to merge 1 commit into
Rabsztok wants to merge 1 commit into
Conversation
Decisions: - API drops UUID mailsend_domain_id/mailsend_domain_name for integer domain_id/domain_name; spec follows - type removed: always ContactsEmailCampaign, carries no information - reject_count removed from stats: not exposed anywhere else publicly
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe email campaign OpenAPI schema replaces UUID ChangesEmail campaign API schema
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Rabsztok
marked this pull request as ready for review
July 31, 2026 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://railsware.atlassian.net/browse/MT-23324
Use correct attribute names for email campaigns API endpoints
Changes
EmailCampaignschema:typeremoved; UUIDmailsend_domain_id/mailsend_domain_namereplaced with integerdomain_id/domain_nameEmailCampaignStats:reject_countremovedHow to test
domain_id/domain_name, notype/mailsend_*reject_countSummary by CodeRabbit
reject_countfield from campaign statistics.