Fix inbound_inbox_id webhook field: optional, not required - #49
Open
mklocek wants to merge 1 commit into
Open
Conversation
inbound_inbox_id is optional for inbound_receiving webhooks; omitting it applies the webhook to all inboxes in the account. It is not required.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe webhook creation schema now permits omitting ChangesInbound webhook scope
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the
inbound_inbox_iddescription on the create-webhook request. It was documented as required forinbound_receivingwebhooks, but it is actually optional — omitting it applies the webhook to all inboxes in the account.Change
specs/email-sending.openapi.yml, create-webhook request body:The
inbound_inbox_iddescriptions on the update-webhook request and the webhook response already read "Applicable only forinbound_receivingwebhooks" and are unchanged.Why
The misleading "required" wording propagated into the SDKs during backfill (PHP enforced it with a
throw; Ruby/MCP documented it). All are being corrected; this fixes the source of truth.Summary by CodeRabbit