Repository navigation
feat(twin): keep bot rejects out of Phoenix (tail sampling) - #18
Merged
Merged
Conversation
…eps them ~99% of twin requests are scanners/crawlers (method_not_allowed, forbidden_origin). A Phoenix-only tail_sampling policy drops those whole traces so real conversations stay visible; Tempo/ClickHouse and the digital-twin-traces dashboard still count them. Verified through the tunnel: bot reject 2 spans in Tempo / 0 in Phoenix, answered trace in both. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AnNpvt9FGCYPErJvHzyji5
Contributor
Merge Queue Status
This pull request spent 49 seconds in the queue, including 27 seconds running CI. Required conditions to merge
|
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phoenix-only
tail_sampling/twin_phoenixdrops digital-twin traces whose outcome ismethod_not_allowedorforbidden_origin(scanners/crawlers, ~99% of twin requests). Tempo, ClickHouse and thedigital-twin-tracesdashboard keep them. Already live on the host; verified via the tunnel (bot reject: 2 spans in Tempo, 0 in Phoenix; answered: in both).https://claude.ai/code/session_01AnNpvt9FGCYPErJvHzyji5