Repository navigation
Phoenix: derive OpenInference span kinds for traces that lack them - #9
Merged
Merged
Conversation
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Phoenix's "kind" column reads openinference.span.kind, which most of our producers don't set, so their spans showed "unknown". transform/phoenix_kind (traces/phoenix pipeline only) sets it when absent: - specstride: run AGENT, tool TOOL, critic/verification EVALUATOR, agent_text LLM - OpenClaw: run/harness.run AGENT, exec TOOL (its own LLM/TOOL spans are untouched) - any producer: gate/guard/perimeter/killswitch/redact/sensitivity span names GUARDRAIL, everything else CHAIN Tempo/ClickHouse data is unchanged. The comment on the Phoenix project mapping no longer lists specific internal services. Claude-Session: https://claude.ai/code/session_016d5AJ1LjeunQ5sz5XEvxQQ Signed-off-by: mairp <oec.valle.art@gmail.com>
mairp
force-pushed
the
feat/phoenix-span-kinds
branch
from
September 25, 2026 09:00
71fc499 to
acced5f
Compare
mairp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phoenix's kind column reads the OpenInference attribute
openinference.span.kind, not the OTel SpanKind. Most of our producers don't set it, so their spans showedunknown.The new
transform/phoenix_kindprocessor runs in thetraces/phoenixpipeline only, and only sets the kind when the span doesn't already have one:run-> AGENT,tool-> TOOL,critic/verification-> EVALUATOR,agent_text-> LLMopenclaw.run/openclaw.harness.run-> AGENT,openclaw.exec-> TOOL. Spans that already have a kind (model calls LLM, tool executions TOOL) are left as they are.Tempo and ClickHouse data is unchanged.
Verified live: a fresh policy-router trace shows GUARDRAIL on its gate and guard steps and CHAIN on the rest in Phoenix, and the Tempo copy has no
openinferenceattributes.otelcol validatepasses.https://claude.ai/code/session_016d5AJ1LjeunQ5sz5XEvxQQ