Repository navigation
feat: add production requirements report screens - #169
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43e0e3c6ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| next: (depositos) => { | ||
| this.depositos = depositos ?? []; | ||
| this.montarOpcoes(); |
There was a problem hiding this comment.
When both product-range fields are edited in quick succession, each (change) starts a request and every response is accepted. If the earlier request finishes last, it replaces the warehouse and branch options with data for the old range; if it finishes first, it also clears carregandoDepositos while the newer request remains pending, allowing a report to be generated with stale selections. Cancel the previous request or associate each response with the range/request that initiated it.
Useful? React with 👍 / 👎.
| gerar(): void { | ||
| if (!this.faixaValida()) return; | ||
| this.carregando = true; | ||
| this.erro = null; |
There was a problem hiding this comment.
After a report has been generated, starting another request leaves resultado visible, and the error path also preserves it. If the user changes the range or filters and the new request fails, the page therefore shows the new filter controls and an error alongside the previous report, which can be mistaken for results from the current selection. Clear or explicitly mark the existing result as stale when generation starts or fails.
Useful? React with 👍 / 👎.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist: