feat(e2e): skip e2e tests if paused#3685
Merged
Merged
Conversation
bgm-malbeclabs
force-pushed
the
bgm/skip_if_paused
branch
from
052a9b4 to
ebe80f7
Compare
vihu
reviewed
Jun 22, 2026
vihu
left a comment
vihu
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Should fix that sdk-compat test before landing though.
FetchRewardShares/FetchValidatorDebts wrapped whatever the ledger client returned. The gagliardetto RPC reports an absent account as rpc.ErrNotFound, so a missing record did not satisfy errors.Is(err, ErrAccountNotFound). The epoch-scan loop in TestCompatRewardShares relies on that check to skip epochs without a Shapley record, so it fataled on the first missing epoch instead of scanning the window (the sdk-compat-test failure on this PR). Collapse rpc.ErrNotFound into ErrAccountNotFound at a getRecordData choke point used by both fetches; add unit regression tests.
ben-dz
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Update e2e tests to detect if a program is paused rather than run and fail
Closes #3683
Testing Verification