Skip to content

Fix OpenSSL paths for restricted Windows code pages - #471

Merged
MadMaxMangos merged 2 commits into
masterfrom
codex/openssl-utf8-followup
Aug 3, 2026
Merged

Fix OpenSSL paths for restricted Windows code pages#471
MadMaxMangos merged 2 commits into
masterfrom
codex/openssl-utf8-followup

Conversation

@MadMaxMangos

@MadMaxMangos MadMaxMangos commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

  • use API-valid flags and null default-character pointers when the Windows active code page is UTF-8 or GB18030
  • preserve best-fit rejection for other active code pages
  • reject malformed UTF-16 rather than silently substituting replacement characters

This is a focused follow-up to #470. No new tests or database changes are included.

Verification

  • Release mangos_tests target built
  • Release realmd target built
  • existing OpenSSL tests passed (2/164 selected, 0 failed)
  • direct Win32 probes confirmed valid input converts and lone surrogates fail with ERROR_NO_UNICODE_TRANSLATION for code pages 65001 and 54936
  • Devin SWE-1.7 focused re-review: APPROVE

This change is Reviewable

@codacy-production

codacy-production Bot commented Aug 3, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@MadMaxMangos
MadMaxMangos merged commit 713836b into master Aug 3, 2026
7 of 8 checks passed
@MadMaxMangos
MadMaxMangos deleted the codex/openssl-utf8-followup branch August 3, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant