Fixed pause button not working#626
Open
sofian wants to merge 1 commit into
Open
Conversation
aalex
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VideoImpl::setPlayState()wasn't declaredvirtual.VideoPlayerImpldeclares its ownsetPlayState()that does the real work (_player->pause()/_player->play()), but since the base wasn't virtual it was just a separate function hiding the base one — never reachable through theVideoImpl*pointer thatVideo::_doPause()/_doPlay()actually call through. So pausing silently no-opped (just set a bookkeeping flag), while play appeared to work becauseVideoPlayerImpl::loadMovie()calls_player->play()directly on load, independent of this path.Fix: made
VideoImpl::setPlayState()virtual and addedoverrideonVideoPlayerImpl's.Test plan
qmake6 mapmap.pro && makebuilds cleantests/suite builds and all 44 existing Qt Test cases passsetPlayState()through aVideoImpl*base pointer on aVideoPlayerImplwith no movie loaded returnstrue(dispatched to the base no-op) before the fix, andfalse(dispatched to the real derived implementation) after — confirmed both ways