Skip to content

ci: silence avoidable Android emulator warnings - #1629

Open
mrousavy wants to merge 1 commit into
mainfrom
ci/quiet-benchmark-emulator
Open

ci: silence avoidable Android emulator warnings#1629
mrousavy wants to merge 1 commit into
mainfrom
ci/quiet-benchmark-emulator

Conversation

@mrousavy

@mrousavy mrousavy commented Sep 7, 2026

Copy link
Copy Markdown
Member

The Android benchmark emulator's version probe fails while loading libpulse.so.0, then its exit status is hidden by the following acceleration probe. Remove the redundant version command and retain -accel-check, the KVM permission checks, and mandatory hardware acceleration.

Pass -no-metrics explicitly to avoid the emulator's telemetry-consent warning. This disables emulator telemetry only; benchmark result collection is unchanged.

Pre-rebase validation (dce342a62): actionlint with the repository's Blacksmith runner labels (including ShellCheck), workflow tests (4 tests), and git diff --check pass. CI preparation/tooling tests passed.

Rebased onto main's performance-publication artifact update. git range-diff confirms the patch is unchanged; actionlint and ShellCheck pass again. Fresh native CI validation is pending.

@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nitro-docs Ready Ready Preview Sep 7, 2026 7:03pm UTC

Request Review

@mrousavy
mrousavy marked this pull request as ready for review September 7, 2026 18:53
@nitro-modules-bot

Copy link
Copy Markdown

Performance Report

⚠️ Advisory: Results do not fail this PR.

iOS

Benchmark Before After Difference
C++ addNumbers() 102.4 ns 88.0 ns 🟢 -14.07% faster
C++ short ASCII string 153.1 ns 131.1 ns 🟢 -14.41% faster
Swift copy(1 MiB) 90.17 µs 83.57 µs 🟢 -7.33% faster
Swift synchronousCallback() 279.3 ns 256.0 ns 🟢 -8.32% faster
Swift immediatePromise() 1.42 µs 1.52 µs 🔴 +7.22% slower
Swift number | string variant 205.1 ns 192.0 ns 🟢 -6.41% faster
All Benchmarks
Benchmark Before After Difference
JavaScript addNumbers() 22.0 ns 22.1 ns 🔴 +0.3% slower
C++ bounce(1 MiB) 228.0 ns 233.6 ns 🔴 +2.46% slower
C++ bounce(4 KiB) 241.4 ns 235.5 ns 🟢 -2.43% faster
C++ bounce native-owned buffer (1 MiB) 3.70 µs 3.79 µs 🔴 +2.4% slower
C++ bounce native-owned buffer (4 KiB) 383.0 ns 384.7 ns 🔴 +0.43% slower
C++ copy(1 MiB) 74.00 µs 72.42 µs 🟢 -2.14% faster
C++ copy(4 KiB) 1.04 µs 1.04 µs 🟢 -0.1% faster
C++ large array (1,024) 47.18 µs 47.51 µs 🔴 +0.7% slower
C++ small array (16) 948.9 ns 912.2 ns 🟢 -3.86% faster
C++ synchronousCallback() 193.0 ns 198.7 ns 🔴 +2.95% slower
C++ create() 430.5 ns 442.4 ns 🔴 +2.76% slower
C++ returnExisting() 210.1 ns 203.3 ns 🟢 -3.25% faster
C++ typed map (8 entries) 1.74 µs 1.70 µs 🟢 -2.34% faster
C++ optional trailing string 149.0 ns 145.6 ns 🟢 -2.25% faster
C++ simpleFunc() 66.7 ns 63.6 ns 🟢 -4.66% faster
C++ deferred worker Promise (includes trigger call) 20.93 µs 21.21 µs 🔴 +1.36% slower
C++ immediatePromise() 838.3 ns 812.8 ns 🟢 -3.04% faster
C++ number property get/set 134.1 ns 133.2 ns 🟢 -0.67% faster
C++ Unicode string 276.2 ns 279.7 ns 🔴 +1.24% slower
C++ nested Car struct 2.40 µs 2.44 µs 🔴 +1.88% slower
C++ number | string variant 130.9 ns 132.3 ns 🔴 +1.05% slower
Swift bounce(1 MiB) 263.2 ns 261.4 ns 🟢 -0.7% faster
Swift bounce(4 KiB) 238.6 ns 247.5 ns 🔴 +3.73% slower
Swift bounce native-owned buffer (1 MiB) 3.99 µs 3.94 µs 🟢 -1.05% faster
Swift bounce native-owned buffer (4 KiB) 404.8 ns 406.5 ns 🔴 +0.42% slower
Swift copy(4 KiB) 1.25 µs 1.30 µs 🔴 +4.01% slower
Swift large array (1,024) 49.56 µs 48.23 µs 🟢 -2.69% faster
Swift small array (16) 999.4 ns 998.0 ns 🟢 -0.15% faster
Swift create() 27.76 µs 27.71 µs 🟢 -0.19% faster
Swift returnExisting() 257.8 ns 254.7 ns 🟢 -1.19% faster
Swift typed map (8 entries) 2.43 µs 2.38 µs 🟢 -2.17% faster
Swift optional trailing string 157.1 ns 155.2 ns 🟢 -1.2% faster
Swift addNumbers() 75.6 ns 77.2 ns 🔴 +2.06% slower
Swift simpleFunc() 62.6 ns 61.4 ns 🟢 -1.83% faster
Swift deferred worker Promise (includes trigger call) 41.49 µs 39.53 µs 🟢 -4.74% faster
Swift number property get/set 137.1 ns 136.2 ns 🟢 -0.71% faster
Swift short ASCII string 155.9 ns 157.5 ns 🔴 +1.04% slower
Swift Unicode string 344.5 ns 342.4 ns 🟢 -0.59% faster
Swift nested Car struct 2.46 µs 2.48 µs 🔴 +1.2% slower
TurboModule addNumbers() 941.1 ns 908.8 ns 🟢 -3.42% faster

Android

Benchmark Before After Difference
JavaScript addNumbers() 23.8 ns 20.2 ns 🟢 -14.75% faster
C++ copy(1 MiB) 25.30 µs 23.97 µs 🟢 -5.25% faster
C++ copy(4 KiB) 763.1 ns 723.0 ns 🟢 -5.26% faster
C++ large array (1,024) 34.51 µs 36.38 µs 🔴 +5.4% slower
C++ create() 542.9 ns 494.8 ns 🟢 -8.87% faster
C++ deferred worker Promise (includes trigger call) 21.07 µs 19.94 µs 🟢 -5.35% faster
Kotlin bounce native-owned buffer (1 MiB) 3.71 µs 3.92 µs 🔴 +5.48% slower
Kotlin copy(1 MiB) 253.45 µs 266.54 µs 🔴 +5.17% slower
Kotlin create() 1.37 µs 1.63 µs 🔴 +18.89% slower
All Benchmarks
Benchmark Before After Difference
C++ bounce(1 MiB) 419.1 ns 399.5 ns 🟢 -4.67% faster
C++ bounce(4 KiB) 417.3 ns 416.3 ns 🟢 -0.24% faster
C++ bounce native-owned buffer (1 MiB) 3.18 µs 3.07 µs 🟢 -3.63% faster
C++ bounce native-owned buffer (4 KiB) 432.1 ns 424.4 ns 🟢 -1.79% faster
C++ small array (16) 745.3 ns 744.3 ns 🟢 -0.14% faster
C++ synchronousCallback() 297.6 ns 291.7 ns 🟢 -2.01% faster
C++ returnExisting() 206.1 ns 204.7 ns 🟢 -0.66% faster
C++ typed map (8 entries) 1.61 µs 1.55 µs 🟢 -3.86% faster
C++ optional trailing string 140.0 ns 141.6 ns 🔴 +1.17% slower
C++ addNumbers() 84.3 ns 81.8 ns 🟢 -2.95% faster
C++ simpleFunc() 68.1 ns 69.2 ns 🔴 +1.7% slower
C++ immediatePromise() 801.1 ns 795.1 ns 🟢 -0.75% faster
C++ number property get/set 143.3 ns 148.8 ns 🔴 +3.83% slower
C++ short ASCII string 128.1 ns 127.9 ns 🟢 -0.16% faster
C++ Unicode string 235.3 ns 237.9 ns 🔴 +1.11% slower
C++ nested Car struct 1.95 µs 1.96 µs 🔴 +0.79% slower
C++ number | string variant 124.2 ns 126.8 ns 🔴 +2.09% slower
Kotlin bounce(1 MiB) 945.6 ns 966.0 ns 🔴 +2.16% slower
Kotlin bounce(4 KiB) 968.3 ns 973.9 ns 🔴 +0.59% slower
Kotlin bounce native-owned buffer (4 KiB) 1.06 µs 1.06 µs 🟢 -0.29% faster
Kotlin copy(4 KiB) 4.34 µs 4.29 µs 🟢 -1.22% faster
Kotlin large array (1,024) 37.90 µs 37.93 µs 🔴 +0.07% slower
Kotlin small array (16) 962.8 ns 961.1 ns 🟢 -0.18% faster
Kotlin synchronousCallback() 960.8 ns 969.2 ns 🔴 +0.87% slower
Kotlin returnExisting() 549.6 ns 545.2 ns 🟢 -0.8% faster
Kotlin typed map (8 entries) 5.74 µs 5.69 µs 🟢 -0.82% faster
Kotlin optional trailing string 302.7 ns 305.7 ns 🔴 +0.99% slower
Kotlin addNumbers() 109.1 ns 112.5 ns 🔴 +3.08% slower
Kotlin simpleFunc() 91.5 ns 92.0 ns 🔴 +0.52% slower
Kotlin deferred worker Promise (includes trigger call) 28.86 µs 29.63 µs 🔴 +2.65% slower
Kotlin immediatePromise() 2.16 µs 2.06 µs 🟢 -4.5% faster
Kotlin number property get/set 214.8 ns 213.3 ns 🟢 -0.69% faster
Kotlin short ASCII string 399.0 ns 395.4 ns 🟢 -0.88% faster
Kotlin Unicode string 662.7 ns 654.4 ns 🟢 -1.25% faster
Kotlin nested Car struct 4.19 µs 4.17 µs 🟢 -0.56% faster
Kotlin number | string variant 361.1 ns 365.1 ns 🔴 +1.11% slower
TurboModule addNumbers() 215.9 ns 209.0 ns 🟢 -3.18% faster

Benchmarking Code Diff 2e815f49...c0662c9d (view raw output)

Raw measurements: performance-report-1 (JSON artifact). Run 34154016158, attempt 1. Download requires GitHub access.

Android: measurements, attempt 1, apps, attempt 1.
iOS: measurements, attempt 1, apps, attempt 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant