fix(core): contextualize runtime function loader failures - #45
Open
huytdps13400 wants to merge 1 commit into
Open
fix(core): contextualize runtime function loader failures#45huytdps13400 wants to merge 1 commit into
huytdps13400 wants to merge 1 commit into
Conversation
Wrap registered runtime-function loaders at the JS boundary and validate results before caching. Report RuntimeFunctionLoadError with function and runtime context, retain the original cause locally, and include its message in serialized errors. Explain non-function results with initialization and missing native-package guidance. Add callable-module regression coverage for thrown, undefined, object, and invalid-cache loader results. Fixes margelo#43
|
@huytdps13400 is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeFunctionLoadErrorcauselocallyThe registered loader is wrapped before it is handed to the JSI registry, while the JS fallback validates before updating its runtime-local cache. Function-body errors remain outside the loader wrapper and keep their existing behavior.
Regression coverage
The new callable-module boundary test covers:
undefinedor an objectError.causeRED before the implementation: 4/4 regression tests failed with the existing plain
Error/TypeErrorbehavior. A separate mutation check removed thecauseattachment and failed specifically on the missing-cause assertion.Verification
Passed locally:
packages/coreTypeScript/plugin buildpackages/stateTypeScript buildtsc --noEmitgit diff --checkRepository-wide baseline limitations:
App.test.tsxbecause the nativeNitroModulesTurboModule is unavailable outside a built app; the other three suites passSupersedes #44, which GitHub closed automatically when its head branch was renamed.
Fixes #43