fix(worklets): don't leak controller setter rejections from bindUIUpdatesToController - #4182
Open
jslok wants to merge 1 commit into
Open
fix(worklets): don't leak controller setter rejections from bindUIUpdatesToController#4182jslok wants to merge 1 commit into
jslok wants to merge 1 commit into
Conversation
…atesToController Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NuPbnK4pvM4qAtKiTWtrAy
|
@jslok is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller setters bound here (
setZoom,setExposureBias, …) return Promises and nothing on the UI runtime handles a rejection. CameraX cancels the previoussetZoomRatiofuture whenever a new one arrives, so an animated zoom driven by a shared value (withDecay/withSpring) produces a burst ofOperationCanceledExceptionrejections, and a value applied while the session is re-configuring rejects with "Camera is not active". They surface as unhandled promise rejections on the UI runtime, and theonErrorrouting from #4101 can't reach this path. This attaches a no-op catch, duck-typed so a void-returning setter keeps working. Follow-up to #3907, which was reported as still reproducing on 5.2.2.🤖 Generated with Claude Code
https://claude.ai/code/session_01NuPbnK4pvM4qAtKiTWtrAy