Repository navigation
Use AwareDateTime when generating field from DateTime(timezone=True) (#407) - #741
Open
DYNOSuprovo wants to merge 1 commit into
Open
DYNOSuprovo wants to merge 1 commit into
DYNOSuprovo wants to merge 1 commit into
Conversation
…arshmallow-code#407) Signed-off-by: DYNOSuprovo <DYNOSuprovo@users.noreply.github.com>
Member
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #407.
Summary
When generating a marshmallow field for a SQLAlchemy column of type
DateTime(timezone=True)(or dialect equivalents such aspostgresql.TIMESTAMP(timezone=True),mysql.DATETIME(timezone=True), andmssql.DATETIMEOFFSET),ModelConvertercurrently generates a defaultfields.DateTime. This forces schemas to explicitly override auto-generated fields withfields.AwareDateTime.Solution
_datetime_field_factoryand registeredsa.DateTimeandmysql.DATETIMEinModelConverter.SQLA_TYPE_MAPPING.getattr(data_type, "timezone", False)isTrue(or if it is an instance ofmssql.DATETIMEOFFSET), the factory returnsfields.AwareDateTime.converter.type_mapping.get(dt.datetime, fields.DateTime), fully preserving existing behavior and custom schemaTYPE_MAPPINGoverrides for naive datetimes.tests/test_conversion.pyfor standard and dialect types (sa.DateTime,postgresql.TIMESTAMP,mysql.DATETIME,mssql.DATETIMEOFFSET,sa.TIMESTAMP) and intests/test_sqlalchemy_schema.pyforSQLAlchemyAutoSchema.