Skip to content

solution - #187

Open
AngelaStrechen wants to merge 7 commits into
mate-academy:masterfrom
AngelaStrechen:develop
Open

AngelaStrechen wants to merge 7 commits into
mate-academy:masterfrom
AngelaStrechen:develop

Conversation

@AngelaStrechen

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, to improve:

  1. fix that image
Image
  1. remove horizontal scrolling (i guess the problem is in the header section)
Image

@brespect brespect left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, check next:

  1. Add a more informative favicon.

  2. Form after submit should not jump the page to the top.

  3. Autofill fields should not be invisible after selection, it reveals only when I press "space" button on my keyboard:

Image

@2pasha 2pasha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👏

here are some improvements:

  1. after form submit - form should be reseted. (no scroll, no redirects)

  2. add some placeholders for city as well

Image
  1. add ability to enter only digits in card number field
Image
  1. it will be great to implement the third step confirmation, because right now it looks unfinished
Image
  1. if i open all FAQ block looks broken
Image
  1. disable page scrolling when burger menu is opened

  2. FAQ for mobile and tablet doesn't work good

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants