fix(colexec): honor cancellation in window pipelines#26080
Merged
mergify[bot] merged 6 commits intoJul 24, 2026
Merged
Conversation
Poll query cancellation during long-running window frame evaluation and partition output so KILL QUERY and KILL CONNECTION can stop the pipeline promptly. Add deterministic cancellation and cleanup regressions. Fixes matrixorigin#26067
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
XuPeng-SH
approved these changes
Jul 24, 2026
XuPeng-SH
left a comment
XuPeng-SH
left a comment
Contributor
There was a problem hiding this comment.
Deep-reviewed at e6c5220. Cancellation polling covers the long-running window frame/value/order paths and partition output; error exits are reclaimed through the existing Reset/Free lifecycle, and the operator protocol remains intact. Verified the new cancellation tests repeatedly, both owning packages in full and under race, plus the compile integration dependency. CI is green. No blocking findings.
Contributor
Merge Queue Status
This pull request spent 2 hours 3 minutes 28 seconds in the queue, including 1 hour 3 minutes 11 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poll query cancellation during long-running window frame evaluation and partition output so KILL QUERY and KILL CONNECTION can stop the pipeline promptly. Add deterministic cancellation and cleanup regressions.
Fixes #26067
What type of PR is this?
Which issue(s) this PR fixes:
issue #26067
What this PR does / why we need it:
fix(colexec): honor cancellation in window pipelines