Repository navigation
Fix media broker connections, empty embed publishing and compiler warnings - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long media commands could exhaust the broker's lifetime budget of 4,096 connections and fail subsequent FFmpeg requests with connection refused. The broker now limits concurrent connections instead, releases slots when sockets close, and keeps the control channel available when the limit is reached. Cancellation still closes active connections.
Empty embeds could also remain in
publishingwhen switching from private to public because origin verification required a manifest that does not exist yet. A missing manifest is now accepted in either direction only when the asset has no current video, after policy synchronization and cache purging succeed. Existing videos and storage authorization failures still fail verification.The broker and playback fixes are separate commits. A third commit removes unreachable private branches identified by Elixir 1.20, preserves explicit file-write error handling, and corrects AIFF/AIFC signature matching to read a four-byte form type, covered by a regression test.
Validation:
go vet, and three race-detector runs passed.git diff --checkpassed.The broker change requires rebuilding the CPU encoding booster image; the playback change requires rebuilding the application. No database migration is needed.